Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

No Sync label in settings' sidebar #2593

Closed
btlechowski opened this issue Dec 17, 2018 · 6 comments · Fixed by brave/brave-core#1157
Closed

No Sync label in settings' sidebar #2593

btlechowski opened this issue Dec 17, 2018 · 6 comments · Fixed by brave/brave-core#1157
Assignees
@darkdh
Labels
feature/global-settings Settings at browser level independent of shields settings feature/sync QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-Plan-Specified QA/Yes release-notes/exclude
Milestone
0.59.x - Release ...

Comments

@btlechowski
Copy link

btlechowski commented Dec 17, 2018 •
edited by kjozwiak
Loading

Follow up from #1183

Steps to Reproduce

  1. Go to brave://settings
  2. Show sidebar

Actual result:

The is no Sync label in sidebar

image

screen shot 2018-12-18 at 1 44 31 am

Expected result:

Sync label is in sidebar

Brave version (brave://version info)

Brave 0.58.14 Chromium: 71.0.3578.98 (Official Build) (64-bit)
Revision 15234034d19b85dcd9a03b164ae89d04145d8368-refs/branch-heads/3578@{#897}
OS Windows 7

@rebron @cezaraugusto @brave/legacy_qa
@btlechowski btlechowski added feature/global-settings Settings at browser level independent of shields settings feature/sync QA/Yes QA/Test-Plan-Specified labels Dec 17, 2018
@btlechowski btlechowski added this to the 0.58.x - Release milestone Dec 17, 2018
@btlechowski btlechowski changed the title Create Sync label in settings' sidebar No Sync label in settings' sidebar Dec 17, 2018
@btlechowski btlechowski mentioned this issue Dec 17, 2018
Closed
@LaurenWags
Copy link
Member

Reproduces on macOS

Brave 0.58.14 Chromium: 71.0.3578.98 (Official Build) (64-bit)
Revision 15234034d19b85dcd9a03b164ae89d04145d8368-refs/branch-heads/3578@{#897}
OS Mac OS X

@cezaraugusto
Copy link
Contributor

cc @darkdh

@darkdh
Copy link
Member

darkdh commented Dec 17, 2018

@bradleyrichter do we need this? we haven't added any of our stuff like "Brave Shield" and "Brave Sync" into the sidebar

@cezaraugusto
Copy link
Contributor

moving to 0.59 per last sync meeting

@btlechowski
Copy link
Author

Reproduces on Ubuntu 17.10

Brave 0.58.14 Chromium: 71.0.3578.98 (Official Build) (64-bit)
Revision 15234034d19b85dcd9a03b164ae89d04145d8368-refs/branch-heads/3578@{#897}
OS Linux

@darkdh darkdh self-assigned this Dec 19, 2018
@darkdh darkdh mentioned this issue Dec 20, 2018
Merged
18 tasks
@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Dec 29, 2018 •
edited
Loading

Verification passed on

Brave 0.59.13 Chromium: 72.0.3626.28 (Official Build) beta (64-bit)
Revision 997b1040b63bac324e815797ba52be0cd8f616ed-refs/branch-heads/3626@{#461}
OS Windows

image

Verification passed on

Brave 0.59.13 Chromium: 72.0.3626.28 (Official Build) beta (64-bit)
Revision 997b1040b63bac324e815797ba52be0cd8f616ed-refs/branch-heads/3626@{#461}
OS Linux

Verification PASSED on macOS 10.14.2 x64 using the following build:

Brave 0.59.14 Chromium: 72.0.3626.28 (Official Build) beta(64-bit)
Revision 997b1040b63bac324e815797ba52be0cd8f616ed-refs/branch-heads/3626@{#461}
OS Mac OS X

screen shot 2019-01-03 at 11 13 48 am

@kjozwiak kjozwiak mentioned this issue Feb 1, 2019
Closed
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@darkdh darkdh

Labels
feature/global-settings Settings at browser level independent of shields settings feature/sync QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-Plan-Specified QA/Yes release-notes/exclude
Projects
None yet
Milestone
0.59.x - Release (Release Channel)
Development

Successfully merging a pull request may close this issue.

Add sync to setting menu brave/brave-core
7 participants
@bbondy @kjozwiak @cezaraugusto @darkdh @LaurenWags @btlechowski @GeetaSarvadnya