Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Brave sync is not renamed to Sync on Linux platform #2758

Closed
GeetaSarvadnya opened this issue Dec 29, 2018 · 8 comments
Closed

Brave sync is not renamed to Sync on Linux platform #2758

GeetaSarvadnya opened this issue Dec 29, 2018 · 8 comments

Comments

@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Dec 29, 2018

Description

Brave sync is not renamed to Sync in the following places:

  1. Hamburger menu
  2. brave://settings sidebar menu
  3. brave://settings -Brave sync section

Steps to Reproduce

  1. Clean profile 0.59.13

Actual result:

Hamburger menu:

image

Brave://settings sidebar:

image

Brave://settings ->Brave sync section

image

Expected result:

Brave Sync should be renamed to Sync

Reproduces how often:

Always

Brave version (brave://version info)

Brave 0.59.13 Chromium: 72.0.3626.28 (Official Build) beta (64-bit)
Revision 997b1040b63bac324e815797ba52be0cd8f616ed-refs/branch-heads/3626@{#461}
OS Linux

Reproducible on current release:na

  • Does it reproduce on brave-browser dev/beta builds? yes

Website problems only: na

  • Does the issue resolve itself when disabling Brave Shields? na
  • Is the issue reproducible on the latest version of Chrome? na

Additional Information

@brave/legacy_qa

@GeetaSarvadnya GeetaSarvadnya added this to the 1.x Backlog milestone Dec 29, 2018
@GeetaSarvadnya GeetaSarvadnya changed the title Brave sync is not renamed to Sync in Hamburger menu on Linux platform Brave sync is not renamed to Sync in Hamburger menu and brave://settings sidebar menu on Linux platform Dec 29, 2018
@GeetaSarvadnya GeetaSarvadnya changed the title Brave sync is not renamed to Sync in Hamburger menu and brave://settings sidebar menu on Linux platform Brave sync is not renamed to Sync on Linux platform Dec 29, 2018
@LaurenWags
Copy link
Member

Does not reproduce on macOS using the below build

Brave 0.59.14 Chromium: 72.0.3626.28 (Official Build) beta(64-bit)
Revision 997b1040b63bac324e815797ba52be0cd8f616ed-refs/branch-heads/3626@{#461}
OS Mac OS X

screen shot 2019-01-02 at 1 32 09 pm

@btlechowski
Copy link

Does not reproduce on Ubuntu 17.10 with the new build

Brave 0.59.14 Chromium: 72.0.3626.28 (Official Build) beta(64-bit)
Revision 997b1040b63bac324e815797ba52be0cd8f616ed-refs/branch-heads/3626@{#461}
OS Linux

image

@btlechowski btlechowski modified the milestones: 1.x Backlog, Dupe / Invalid / Not actionable Jan 3, 2019
@srirambv
Copy link
Contributor

srirambv commented Jan 3, 2019

I can reproduce this issue on my Linux machine(Not VM) running Ubuntu 18.04.1

@srirambv srirambv reopened this Jan 3, 2019
@srirambv srirambv removed this from the Dupe / Invalid / Not actionable milestone Jan 3, 2019
@srirambv srirambv added this to the 1.x Backlog milestone Jan 3, 2019
@srirambv
Copy link
Contributor

srirambv commented Jan 3, 2019

here's the recording on a clean profile https://youtu.be/04K6JYI9Y2E

@kjozwiak
Copy link
Member

kjozwiak commented Jan 4, 2019

Seeing the same thing under Mint 18.3 x64 VM & Ubuntu 18.04.1 LTS x64 using the following build:

Brave 0.59.18 Chromium: 72.0.3626.28 (Official Build) beta (64-bit)
Revision 997b1040b63bac324e815797ba52be0cd8f616ed-refs/branch-heads/3626@{#461}
OS Linux

Examples:

screen shot 2019-01-04 at 1 42 44 am

screen shot 2019-01-04 at 1 43 00 am

screen shot 2019-01-04 at 1 43 08 am

@kjozwiak kjozwiak added QA/Yes and removed needs-investigation A bug not 100% confirmed/fixed labels Jan 4, 2019
@srirambv srirambv added the priority/P3 The next thing for us to work on. It'll ride the trains. label Jan 15, 2019
@rebron rebron removed this from the 1.x Backlog milestone Feb 7, 2019
@AlexeyBarabash
Copy link
Contributor

Don't see it in

Brave 0.59.35 Chromium: 72.0.3626.81 (Official Build) (64-bit)
Revision ac8b982e05014492d1bd7d317628a4f22a97ffa0-refs/branch-heads/3626@{#796}
OS Linux

image

@kjozwiak
Copy link
Member

kjozwiak commented Feb 13, 2019

Thanks for double checking @AlexeyBarabash 👍 I checked Ubuntu 18.04 x64 VM and Mint 19.1 x64 VM using 0.59.35 and I'm also seeing Sync instead of Brave Sync. Checked the following:

  • checked the hamburger menu and ensured it appeared as Sync
  • checked brave://settings and ensured that the sidebar appeared as Sync
  • checked brave://settings and the sync section is titled as Sync

Example:

screen shot 2019-02-13 at 2 03 57 pm

@GeetaSarvadnya mind checking to see if it's working for you now?

@GeetaSarvadnya
Copy link
Author

GeetaSarvadnya commented Apr 25, 2019

The issue is fixed and working fine. Verified on below version Linux mint -
0.63.48 and 0.64.62

image

@kjozwiak kjozwiak added closed/invalid and removed OS/Linux QA/Yes bug closed/no-milestone feature/sync priority/P3 The next thing for us to work on. It'll ride the trains. labels May 7, 2019
@NejcZdovc NejcZdovc added this to the Dupe / Invalid / Not actionable milestone Jun 3, 2019
@bbondy bbondy removed this from the Dupe / Invalid / Not actionable milestone May 30, 2020
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

No branches or pull requests

9 participants