Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Add Copy Text from Image to image context menu (macOS) #27513

Closed
simonhong opened this issue Dec 22, 2022 · 6 comments · Fixed by brave/brave-core#16508
Closed

Add Copy Text from Image to image context menu (macOS) #27513

simonhong opened this issue Dec 22, 2022 · 6 comments · Fixed by brave/brave-core#16508
Assignees
@simonhong
Labels
OS/Desktop OS/macOS priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-macOS QA/Test-Plan-Specified QA/Yes release-notes/include
Milestone
1.49.x - Release

Comments

@simonhong
Copy link
Member

Add similar feature of FF's Copy Text From Image.
Screenshot 2022-12-22 at 1 51 26 PM

When select that entry, browser launches a dialog and that dialog contains text from image.
@simonhong simonhong self-assigned this Dec 22, 2022
@rebron rebron added the priority/P3 The next thing for us to work on. It'll ride the trains. label Dec 22, 2022
@simonhong simonhong added QA/Yes and removed QA/No labels Dec 23, 2022
@simonhong simonhong mentioned this issue Jan 3, 2023
Merged
25 tasks
simonhong added a commit to brave/brave-core that referenced this issue Jan 6, 2023
@simonhong
Introduced copy text from image feature on macOS
1f145cb 
fix brave/brave-browser#27513

"Copy Text From Image" entry is added to render view's context menu.
It gets bitmap data from renderer via LocalFrame::GetImage() mojom interface,
and then passed it to TextRecognitionDialog to extract and show text from that
image.
simonhong added a commit to brave/brave-core that referenced this issue Jan 13, 2023
@simonhong
Introduced copy text from image feature on macOS
9cf444c 
fix brave/brave-browser#27513

"Copy Text From Image" entry is added to render view's context menu.
It gets bitmap data from renderer via LocalFrame::GetImage() mojom interface,
and then passed it to TextRecognitionDialog to extract and show text from that
image.
@brave-builds brave-builds added this to the 1.49.x - Nightly milestone Jan 13, 2023
@stephendonner
Copy link

stephendonner commented Feb 14, 2023 •
edited
Loading

Verified PASSED using

Brave 1.49.96 Chromium: 110.0.5481.77 (Official Build) beta (x86_64)
Revision 65ed616c6e8ee3fe0ad64fe83796c020644d42af-refs/branch-heads/5481@{#839}
OS macOS Version 11.7.3 (Build 20G1116)

Steps

  1. installed 1.49.96
  2. launched Brave
  3. loaded search.brave.com
  4. searched for various memes
  5. context-clicked on images with text
  6. chose Copy Text from Image
  7. compared the digested text is pretty close to the original text
  8. also tested using images.google.com

Confirmed Copy Text From Image does pretty well with long text, punctuation marks, and at least one additional non-English language, Spanish

search.brave.com:

example example example
Screen Shot 2023-02-13 at 8 48 01 PM Screen Shot 2023-02-13 at 8 48 32 PM Screen Shot 2023-02-13 at 8 50 33 PM

search.google.com:

example example example
Screen Shot 2023-02-13 at 8 41 17 PM Screen Shot 2023-02-13 at 8 42 09 PM Screen Shot 2023-02-13 at 8 44 18 PM

@LaurenWags LaurenWags mentioned this issue Mar 8, 2023
Closed
@Dineshsahteli
Copy link

image

@luquinhaspmw
Copy link

Not working on my Brave V 1.49.120 - Windows 10 - x64

@uzuki7777
Copy link

Same I'm also on windows 10 I don't see it working. Maybe it only works on Mac?

@luquinhaspmw
Copy link

Same I'm also on windows 10 I don't see it working. Maybe it only works on Mac?

I think so

@bsclifton
Copy link
Member

bsclifton commented Mar 12, 2023 •
edited
Loading

@uzuki7777 correct - only works on macOS at the moment

I created #29003 to track

@bsclifton bsclifton mentioned this issue Mar 12, 2023
Closed
@rebron rebron changed the title Add Copy Text From Image entry to image's context menu Add Copy Text from Image to image context menu (macOS) Apr 4, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@simonhong simonhong

Labels
OS/Desktop OS/macOS priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-macOS QA/Test-Plan-Specified QA/Yes release-notes/include
Projects
None yet
Milestone
1.49.x - Release
Development

Successfully merging a pull request may close this issue.

Introduced copy text from image feature on macOS brave/brave-core
8 participants
@stephendonner @bsclifton @rebron @simonhong @brave-builds @luquinhaspmw @Dineshsahteli @uzuki7777