Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Brave News Customize window is blank after loading Learn More content in its tab #27914

Closed
stephendonner opened this issue Jan 19, 2023 · 5 comments · Fixed by brave/brave-core#16788

Comments

@stephendonner
Copy link

Description

Brave News Customize window is blank after loading Learn More content in its tab

This is a followup from #27052, with different steps.

Steps to Reproduce

  1. install 1.49.39
  2. launch Brave
  3. open a new-tab page
  4. scroll down
  5. on the Brave News opt-in dialog, click Learn More (this replaces the tab’s content)
  6. now click the Back button on the browser
  7. click Show Brave News
  8. click Customize

Actual result:

Screen Shot 2023-01-19 at 2 28 00 PM

Expected result:

Screen Shot 2023-01-19 at 2 28 22 PM

Reproduces how often:

100%

Brave version (brave://version info)

Brave 1.49.39 Chromium: 109.0.5414.87 (Official Build) nightly (x86_64)
Revision 2dc18eb511c56e012081b4abc9e38c81c885f7d4-refs/branch-heads/5414@{#1241}
OS macOS Version 11.7.2 (Build 20G1020)

Version/Channel Information:

  • Can you reproduce this issue with the current release?
  • Can you reproduce this issue with the beta channel?
  • Can you reproduce this issue with the nightly channel?

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

/cc @fallaciousreasoning @rebron @mattmcalister @brave/qa-team @petemill

@stephendonner
Copy link
Author

Verified PASSED using

Brave 1.50.14 Chromium: 110.0.5481.77 (Official Build) nightly (x86_64)
Revision 65ed616c6e8ee3fe0ad64fe83796c020644d42af-refs/branch-heads/5481@{#839}
OS macOS Version 11.7.3 (Build 20G1116)

Steps:

  1. installed 1.50.14
  2. launched Brave
  3. opened a new-tab page
  4. scrolled down
  5. on the Brave News opt-in dialog, clicked Learn More (this replaces the tab’s content)
  6. now clicked the Back button on the browser
  7. clicked Show Brave News
  8. clicked Customize

Confirmed I had a working Brave News Customize dialog

Screen Shot 2023-02-07 at 12 51 59 AM

@stephendonner
Copy link
Author

@fallaciousreasoning I hit this in 1.49.100 yesterday; think we can get this uplifted?

@fallaciousreasoning
Copy link

Good call @stephendonner - uplift request is here:
brave/brave-core#17287

@kjozwiak
Copy link
Member

The above requires 1.49.109 or newer for 1.49.x verification 👍 Removing the QA Pass label as this will need to be re-verified on 1.49.x. Used the verification from #27914 (comment) when uplifting brave/brave-core#17287.

@stephendonner
Copy link
Author

Verified PASSED using

Brave 1.49.109 Chromium: 110.0.5481.177 (Official Build) beta (x86_64)
Revision f34f7ab2d4ca4ad498ef42aeba4f4eb2c1392d63-refs/branch-heads/5481@{#1239}
OS macOS Version 11.7.4 (Build 20G1120)
example example example example example
Screen Shot 2023-02-23 at 5 48 39 PM Screen Shot 2023-02-23 at 5 48 49 PM Screen Shot 2023-02-23 at 5 48 52 PM Screen Shot 2023-02-23 at 5 48 59 PM Screen Shot 2023-02-23 at 5 49 04 PM

# for free to join this conversation on GitHub. Already have an account? # to comment