Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Copy keyboard shortcut is not assigned to "copy clean link" in context menu on Linux #28891

Closed
btlechowski opened this issue Mar 3, 2023 · 3 comments · Fixed by brave/brave-core#17487

Comments

@btlechowski
Copy link

btlechowski commented Mar 3, 2023

Follow up from #26761
This is a visual bug. The control+c shortcut actually works as copy clean link

Steps to Reproduce

  1. new profile
  2. launched Brave
  3. loaded https://twitter.com/fmarier/status/1574869891978784769?s=21&t=lkfjeslkfjes&fbclid=1234
  4. selected the whole URL
  5. right click to open context menu

Actual result:

Copy keyboard shortcut is not assigned to "copy clean link" on Linux
image

Expected result:

Copy keyboard shortcut is assigned to "copy clean link" on Linux

Reproduces how often:

Easily reproduced

Brave version (brave://version info)

Brave 1.49.118 Chromium: 111.0.5563.50 (Official Build) (64-bit)
Revision 39f3dfc5023fe60997adc4f6cf5439cfa3e6968a-refs/branch-heads/5563@{#903}
OS Ubuntu 18.04 LTS

Version/Channel Information:

  • Can you reproduce this issue with the current release? yes
  • Can you reproduce this issue with the beta channel? yes
  • Can you reproduce this issue with the nightly channel? yes

cc @spylogsster @fmarier @rebron

@kjozwiak
Copy link
Member

The above requires 1.49.126 or higher for 1.49.x verification 👍

@btlechowski
Copy link
Author

Verification passed on

Brave 1.49.126 Chromium: 111.0.5563.64 (Official Build) (64-bit)
Revision c710e93d5b63b7095afe8c2c17df34408078439d-refs/branch-heads/5563@{#995}
OS Ubuntu 18.04 LTS

Verified test plan from the description

Verified Copy clean link has proper short cut assigned:
image

Verified the Copy clean link works as expected
image

Verified keyboard shortcut for Copy clean link works as expected
image

@Ayern12
Copy link

Ayern12 commented Mar 21, 2023 via email

# for free to join this conversation on GitHub. Already have an account? # to comment