Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

WebImageDownloader will cause a crash if passed url is invalid #32419

Closed
nuo-xu opened this issue Aug 21, 2023 · 0 comments · Fixed by brave/brave-core#19796
Closed

WebImageDownloader will cause a crash if passed url is invalid #32419

nuo-xu opened this issue Aug 21, 2023 · 0 comments · Fixed by brave/brave-core#19796
Labels
OS/iOS Fixes related to iOS browser functionality QA/No release-notes/exclude
Milestone
1.59.x - Release

Comments

@nuo-xu
Copy link

nuo-xu commented Aug 21, 2023

validate net::GURLWithNSURL(url) before calling DownloadImage since it will cause a crash if the generated GURL is invalid.
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
OS/iOS Fixes related to iOS browser functionality QA/No release-notes/exclude
Projects
Web3
Archived in project
Milestone
1.59.x - Release
Development

Successfully merging a pull request may close this issue.

Fix #32419: Fixes crash in WebImageDownloader for iOS brave/brave-core
4 participants
@nuo-xu @Brandon-T @LaurenWags @brave-builds