Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Fix #7907: Crash when downloading images in Wallet with invalid URL #7908

Merged
merged 1 commit into from
Aug 21, 2023

Conversation

StephenHeaps
Copy link
Contributor

Summary of Changes

This pull request fixes #7907

Submitter Checklist:

  • Unit Tests are updated to cover new or changed functionality
  • User-facing strings use NSLocalizableString()
  • New or updated UI has been tested across:
    • Light & dark mode
    • Different size classes (iPhone, landscape, iPad)
    • Different dynamic type sizes

Test Plan:

  1. Open Swap and change network to Polygon
  2. Verify no crash when AAVE token is displayed (should be default to token)
  3. Open Portfolio and tap Edit User Assets button
  4. Optional: change network filters to only have Polygon selected
  5. Scroll to bottom of the list
  6. Verify no crash when AAVE token is displayed/used

Screenshots:

image.download.crash.resolved.mp4

Reviewer Checklist:

  • Issues include necessary QA labels:
    • QA/(Yes|No)
    • bug / enhancement
  • Necessary security reviews have taken place.
  • Adequate unit test coverage exists to prevent regressions.
  • Adequate test plan exists for QA to validate (if applicable).
  • Issue and pull request is assigned to a milestone (should happen at merge time).

@StephenHeaps StephenHeaps self-assigned this Aug 21, 2023
@StephenHeaps StephenHeaps requested a review from a team as a code owner August 21, 2023 18:11
@StephenHeaps StephenHeaps added this to the 1.57 milestone Aug 21, 2023
@StephenHeaps StephenHeaps merged commit 4d6226a into development Aug 21, 2023
@StephenHeaps StephenHeaps deleted the wallet/invalid-image-url-crash branch August 21, 2023 19:48
StephenHeaps added a commit that referenced this pull request Aug 21, 2023
…7908)

Verify given `URL` is a valid before passing to `WebImageDownloader`
arthuredelstein pushed a commit to brave/brave-core that referenced this pull request Feb 13, 2024
…h invalid URL (brave/brave-ios#7908)

Verify given `URL` is a valid before passing to `WebImageDownloader`
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Crash switching to Polygon in Swap
2 participants