This repository has been archived by the owner on May 10, 2024. It is now read-only.
Fix #7907: Crash when downloading images in Wallet with invalid URL #7908
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
WebImageDownloader
from core. Resolves crashes on iOS untilWebImageDownloader
will cause a crash if passed url is invalid brave-browser#32419 is resolved.This pull request fixes #7907
Submitter Checklist:
NSLocalizableString()
Test Plan:
to
token)Screenshots:
image.download.crash.resolved.mp4
Reviewer Checklist:
QA/(Yes|No)
bug
/enhancement