Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Remove Background Sync content setting options #366

Closed
srirambv opened this issue Jun 15, 2018 · 4 comments
Closed

Remove Background Sync content setting options #366

srirambv opened this issue Jun 15, 2018 · 4 comments
Labels
design/needs-mock-up needs-mockup A feature which needs design mockup to be implemented. feature/global-settings Settings at browser level independent of shields settings QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes

Comments

@srirambv
Copy link
Contributor

Description

Background Sync should be removed from Content settings page

Steps to Reproduce

  1. Settings -> Content Settings -> Background Sync which requires account login

Actual result:

image

cc: @bridiver @diracdeltas

@srirambv srirambv added the feature/global-settings Settings at browser level independent of shields settings label Jun 15, 2018
@srirambv srirambv added this to the Releasable builds milestone Jun 15, 2018
@srirambv srirambv changed the title Background Sync should be removed from Content settings page Change Background Sync to Brave Sync Jun 15, 2018
@srirambv srirambv added the design/needs-mock-up needs-mockup A feature which needs design mockup to be implemented. label Jun 15, 2018
@bbondy
Copy link
Member

bbondy commented Aug 16, 2018

I think we'll just remove this option completely? Thoughts @AlexeyBarabash ?

@AlexeyBarabash
Copy link
Contributor

@bbondy @srirambv
I thought this option is for the synchronization of bookmarks/history/setting between devices, which will be replaced with Brave Sync #29 . Then I would vote to remove it.
But if we go there chrome://settings/content/backgroundSync , we will see

image

which is other thing.
So, I think to keep it, and maybe to rename it to Background sync of recently closed sites data .

I was not aware of this option, but it seems useful. If a page has logout button, which works through async JavaScript without re-load of the page, then when user presses logout and immediately closes the tab potentially he would not be logged out in fact. But this option Allow recently closed sites to finish sending and receiving data (recommended) should allow to complete the operation.

The Chrome native sync for bookmarks/history/etc is not currently shown in Brave-core. Two things are required to see that at least:

  1. to re-build with Google API keys with enabled Google Accounts sync;
  2. to login in browser with Google Account.

About this issue: either to keep it as and close, or rename the item. I would just close.

@bbondy
Copy link
Member

bbondy commented Aug 20, 2018

Just going to remove it

bbondy added a commit to brave/brave-core that referenced this issue Aug 20, 2018
@bbondy bbondy changed the title Change Background Sync to Brave Sync Remove Background Sync content setting options Aug 21, 2018
@bbondy bbondy added the QA/Yes label Aug 21, 2018
@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Sep 21, 2018

Verification Passed on:

Brave 0.55.5 Chromium: 70.0.3538.16 (Official Build) dev (64-bit)
Revision 16ed95b41bb05e565b11fb66ac33c660b721f778-refs/branch-heads/3538@{#306}
OS Windows

Verification Passed on

Brave 0.55.5 Chromium: 70.0.3538.16 (Official Build) dev (64-bit)
Revision 16ed95b41bb05e565b11fb66ac33c660b721f778-refs/branch-heads/3538@{#306}
OS Linux

Went through verification using the following build under macOS 10.13.6 x64 - PASSED

Brave 0.55.6 Chromium: 70.0.3538.16 (Official Build) dev (64-bit)
Revision 16ed95b41bb05e565b11fb66ac33c660b721f778-refs/branch-heads/3538@{#306}
OS Mac OS X

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
design/needs-mock-up needs-mockup A feature which needs design mockup to be implemented. feature/global-settings Settings at browser level independent of shields settings QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes
Projects
None yet
Development

No branches or pull requests

5 participants