Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[iOS] Closing tab grays out X in current active tab #37064

Closed
Uni-verse opened this issue Dec 14, 2022 · 1 comment · Fixed by brave/brave-core#23770
Closed

[iOS] Closing tab grays out X in current active tab #37064

Uni-verse opened this issue Dec 14, 2022 · 1 comment · Fixed by brave/brave-core#23770
Assignees

Comments

@Uni-verse
Copy link
Contributor

Description:

Closing active tab grays out X in current active tab

Follow up to brave/brave-ios#6333

Steps to Reproduce

  1. Install 1.46.x
  2. Enable tabs bar
  3. Open at least 4 tabs
  4. Close tab by tapping on X in the active tab

Actual result:
The X shows as grayed out/not in focus

iOSiPadOS
RPReplay_Final1671038565.MP4
RPReplay_Final1671037482.MP4

Expected result:
X in tab bar should not be grayed out

Reproduces how often: [Easily reproduced, Intermittent Issue]
Easily

Brave Version:
1.46 (22.12.13.0)

Device details:
iPhone, iPad

@soner-yuksel soner-yuksel transferred this issue from brave/brave-ios Mar 25, 2024
@kylehickinson kylehickinson added the OS/iOS Fixes related to iOS browser functionality label Mar 25, 2024
@soner-yuksel soner-yuksel changed the title Closing tab grays out X in current active tab [iOS] Closing tab grays out X in current active tab May 21, 2024
@soner-yuksel soner-yuksel self-assigned this May 21, 2024
@brave-builds brave-builds added this to the 1.68.x - Nightly milestone May 24, 2024
@hffvld
Copy link
Contributor

hffvld commented Jul 3, 2024

Verified on iPhone 14 using version(s):

Device/OS: iPhone 14 / iOS 17.6
Brave build: 1.68 (106)
BraveCore: 1.68.106 (126.0.6478.126)

STEPS:

  1. Follow the STR/TP from [iOS] Closing tab grays out X in current active tab #37064 (comment) and [iOS] Tabs Bar Active Tab Issue brave-core#23770 (comment)
  2. Verify

ACTUAL RESULTS:

  • Verified that the x is not getting grayed out when closing the active tab

2024-07-03_16-59-12.mp4

# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants