Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix issues with RequestBlockingScript.js #39546

Closed
3 of 5 tasks
cuba opened this issue Jul 3, 2024 · 1 comment · Fixed by brave/brave-core#24472
Closed
3 of 5 tasks

Fix issues with RequestBlockingScript.js #39546

cuba opened this issue Jul 3, 2024 · 1 comment · Fixed by brave/brave-core#24472
Labels

Comments

@cuba
Copy link

cuba commented Jul 3, 2024

Description

The request blocking script does not emit all the required events that would normally get emitted if content was blocked using the content blocking manager. This causes issues with pages such as youtube forcing us to add a exception rule for youtube

Steps to reproduce

  1. Add a custom rule '||youtube.com/youtubei/v1/log_event?' (wait a few seconds for this to compile)
  2. Click on many videos (maybe 50) (you don't have to watch them just click on them)
  3. Refresh the page

Note: Alternatively you can inspect the web page and see if log items are being removed from the LogsDatabaseV2 as you navigate videos (this saves you from clicking on tens of videos)
Screenshot 2024-07-03 at 8 18 47 AM

Actual result

Page is stuck loading as youtube tries to dump its log queue (unsuccessfully) This happens on every refresh.

Expected result

Page should have normal loading delay

Reproduces how often

Easily reproduced

Brave version

1.66

Device/iOS version

iOS device (not iPad)

Affected browser versions

  • latest AppStore
  • latest TestFlight
  • previous TestFlight

Reproducibility

  • with Brave Shields disabled
  • in the latest version of mobile Safari

Miscellaneous information

No response

@cuba cuba added the OS/iOS Fixes related to iOS browser functionality label Jul 3, 2024
@brave-builds brave-builds added this to the 1.69.x - Nightly milestone Jul 3, 2024
@iccub iccub added the QA/Yes label Jul 3, 2024
@ShivanKaul ShivanKaul added the bug label Jul 8, 2024
@hffvld hffvld added the QA/In-Progress Indicates that QA is currently in progress for that particular issue label Sep 3, 2024
@hffvld
Copy link
Contributor

hffvld commented Sep 3, 2024

Verified on iPhone 14 and iPad Air using version(s):

Device/OS: iPhone 14 / iOS 17.6.1
Brave build: 1.69 (162)
BraveCore: 1.69.162 (128.0.6613.120)

STEPS:

  1. Follow the STR/TP from Fix issues with RequestBlockingScript.js #39546 (comment)
  2. Verify

ACTUAL RESULTS:

  • Verified that YT page is loading with normal delay when refreshing the page after watching a lot of videos (~50)

Reproduced in 1.68.1.145

1 2
1 2

Verified in 1.69.162

2024-09-03_10-10-42.1.mp4

@hffvld hffvld added QA Pass - iPhone and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Sep 3, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants