Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

hamburger menu under Leo panel not working after cancelling Go Premium #39595

Closed
2 of 5 tasks
kjozwiak opened this issue Jul 5, 2024 · 2 comments · Fixed by brave/brave-core#24537
Closed
2 of 5 tasks

Comments

@kjozwiak
Copy link
Member

kjozwiak commented Jul 5, 2024

Description

Similar to brave/brave-core#24488, when you tap on Go Premium and then Cancel, you'll notice that the Hamburger Menu (Settings) button will not work/open the settings panel. You'll have to close/restart Leo for the settings to work in that specific session. It's not reproducible via 1.67.x so assuming it regressed while brave/brave-core#24488 was being fixed.

Steps to reproduce

  1. download/install 1.69.83 Chromium: 127.0.6533.26 via TF
  2. open Leo and run through the onboarding & T&S screens
  3. tap on the Hamburger Menu -> Go Premium -> Cancel

Notice that once you press Cancel via the Go Premium modal/window, the Hamburger button won't work anymore under the Leo panel.

Actual result

Hamburger Menu button/icon should still function/open the settings menu without a need to close/re-open Leo.

Expected result

Hamburger Menu menu should work/open the settings if a user goes into Go Premium and then taps on Cancel.

Reproduces how often

Easily reproduced

Brave version

Brave | 1.69.83 Chromium: 127.0.6533.26 (Official Build) nightly (64-bit) 
--- | ---
Revision | 82eef43ce82a...
OS | iOS

Device/iOS version

  • iPhone 11 running iOS 17.5.1 - Reproduced

Affected browser versions

  • latest AppStore
  • latest TestFlight
  • previous TestFlight

Reproducibility

  • with Brave Shields disabled
  • in the latest version of mobile Safari

Miscellaneous information

No response

@kjozwiak
Copy link
Member Author

kjozwiak commented Jul 9, 2024

The above requires 1.68.116 or higher for 1.68.x verification 👍

@hffvld hffvld added the QA/In-Progress Indicates that QA is currently in progress for that particular issue label Jul 18, 2024
@hffvld
Copy link
Contributor

hffvld commented Jul 18, 2024

Verified on iPhone 14 using version(s):

Device/OS: iPhone 14 / iOS 17.6
Brave build: 1.68 (124)
BraveCore: 1.68.124 (127.0.6533.57)

STEPS:

  1. Follow the STR/TP from [iOS] - Fix Leo popovers not dismissing sometimes & Updated Default Model Text brave-core#24537 (comment)
  2. Verify

ACTUAL RESULTS:

  • Verified that the Leo's Hamburger menu is working as expected after tapping Cancel on Leo Premium paywall.

2024-07-18_13-09-58.mp4

@hffvld hffvld added QA Pass - iPhone and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Jul 18, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

4 participants