Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[iOS] - Fix popover blocking input when backgrounding the app. #24488

Merged
merged 1 commit into from
Jul 3, 2024

Conversation

Brandon-T
Copy link
Contributor

Summary

  • Fix the Leo Menu popover blocking the app from working when backgrounding while it's active since it's not properly removed from the screen when the system automatically dismisses it.

Resolves brave/brave-browser#39109

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@Brandon-T Brandon-T added CI/skip-android Do not run CI builds for Android CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-windows-x64 Do not run CI builds for Windows x64 unused-CI/skip-linux-x64 Do not run CI builds for Linux x64 CI/skip-macos-arm64 Do not run CI builds for macOS arm64 labels Jul 3, 2024
@Brandon-T Brandon-T self-assigned this Jul 3, 2024
@Brandon-T Brandon-T requested a review from a team as a code owner July 3, 2024 17:48
@Brandon-T Brandon-T merged commit b0f7920 into master Jul 3, 2024
20 checks passed
@Brandon-T Brandon-T deleted the bugfix/LeoPopoverInput branch July 3, 2024 19:01
@github-actions github-actions bot added this to the 1.69.x - Nightly milestone Jul 3, 2024
brave-builds added a commit that referenced this pull request Jul 4, 2024
@kjozwiak
Copy link
Member

kjozwiak commented Jul 5, 2024

Verification PASSED on iPhone 11 running iOS 17.5.1 via the following build(s):

Brave | 1.69.83 Chromium: 127.0.6533.26 (Official Build) nightly (64-bit) 
--- | ---
Revision | 82eef43ce82a...
OS | iOS

Using the STR/Cases outlined via brave/brave-browser#39109 (comment), ensured that the Leo settings menu was still working as expected when switching between other applications while the Leo settings menu was visible as per the following:

RPReplay_Final1720222037.MP4

Created/Ran into brave/brave-browser#39595 while verifying the above for uplift.

kjozwiak pushed a commit that referenced this pull request Jul 5, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
CI/skip-android Do not run CI builds for Android CI/skip-macos-arm64 Do not run CI builds for macOS arm64 CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-windows-x64 Do not run CI builds for Windows x64 unused-CI/skip-linux-x64 Do not run CI builds for Linux x64
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Leo screen unresponsive after using app switcher with Leo menu opened
3 participants