Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[Brave Leo]: Update model names in Leo models menu #40464

Closed
LorenzoMinto opened this issue Aug 14, 2024 · 4 comments · Fixed by brave/brave-core#25343
Closed

[Brave Leo]: Update model names in Leo models menu #40464

LorenzoMinto opened this issue Aug 14, 2024 · 4 comments · Fixed by brave/brave-core#25343
Labels
browser-ai needs-text-change This change requires some careful wording. OS/Android Fixes related to Android browser functionality OS/Desktop OS/iOS Fixes related to iOS browser functionality priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass - Android ARM QA Pass - iPhone QA Pass-Win64 QA/Yes release-notes/include

Comments

@LorenzoMinto
Copy link

LorenzoMinto commented Aug 14, 2024

Description

We should update the model names in the model menu:

  • "Llama 3 8B" -> "Llama 3.1 8B"
  • "Claude 3 Sonnet" -> "Claude 3.5 Sonnet"

Current result

Screenshot 2024-08-14 at 18 14 53

cc @mattmcalister @stephendonner

@LorenzoMinto LorenzoMinto added OS/Android Fixes related to Android browser functionality OS/Desktop OS/iOS Fixes related to iOS browser functionality browser-ai labels Aug 14, 2024
@LorenzoMinto LorenzoMinto added priority/P2 A bad problem. We might uplift this to the next planned release. QA/Yes release-notes/include labels Aug 14, 2024
@stephendonner stephendonner added the needs-text-change This change requires some careful wording. label Aug 14, 2024
@mattmcalister mattmcalister moved this to Important / Polish in Browser AI Aug 23, 2024
@rebron rebron moved this from Important / Polish to In Progress in Browser AI Aug 27, 2024
@github-project-automation github-project-automation bot moved this from In Progress to Done in Browser AI Aug 27, 2024
@brave-builds brave-builds added this to the 1.71.x - Nightly milestone Aug 27, 2024
@kjozwiak
Copy link
Member

The above requires 1.69.157 or higher for 1.69.x verification 👍

@GeetaSarvadnya GeetaSarvadnya added the QA/In-Progress Indicates that QA is currently in progress for that particular issue label Aug 28, 2024
@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Aug 28, 2024

Verification PASSED on

Brave | 1.69.157 Chromium: 128.0.6613.85 (Official Build) (64-bit)
-- | --
Revision | 14c4bb724553b882abcd2fccd9b5acf1f177fe6d
OS | Windows 10 Version 22H2 (Build 19045.4780)

Using the STR/Cases outlined via #40464 (comment), ensured that the new strings were being used as per the following:

Example Example
image image

@GeetaSarvadnya GeetaSarvadnya added QA Pass-Win64 and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Aug 28, 2024
@hffvld
Copy link
Contributor

hffvld commented Aug 28, 2024

Verified on Pixel 7 using version(s):

Device/OS: Pixel 7 / panther_beta-user 15 AP41.240726.009 release-keys
Brave build: 1.69.157
Chromium: 128.0.6613.85 (Official Build) (64-bit) 

STEPS:

  1. Launch Leo
  2. Hamburger menu > Leo
  3. ⚙️ > Verify
  4. Advanced Settings
  5. Default model for new conversations > Verify

ACTUAL RESULTS:

  • Verified that Llama 3 8B updated to Llama 3.1 8B
  • Verified that Claude 3 Sonnet updated to Claude 3.5 Sonnet

1 2
1 2

@kjozwiak
Copy link
Member

kjozwiak commented Sep 4, 2024

Verification PASSED on iPhone 11 running iOS 17.6 using the following build(s):

Brave | 1.69.162 Chromium: 128.0.6613.120 (Official Build) stable (64-bit)
--- | ---
Revision | e534755d4eb5...
OS | iOS

Using the STR/Cases outlined via brave/brave-core#25343 (comment), ensured that the correct strings/text was being used as per the following:

  • Llama 3 8B --> Llama 3.1 8B
  • Claude 3 Sonnet --> Claude 3.5 Sonnet
Example Example
IMG_0520 IMG_0521

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
browser-ai needs-text-change This change requires some careful wording. OS/Android Fixes related to Android browser functionality OS/Desktop OS/iOS Fixes related to iOS browser functionality priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass - Android ARM QA Pass - iPhone QA Pass-Win64 QA/Yes release-notes/include
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

6 participants