Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Save to Files is missing from Share menu, and instead Create PDF is shown, which doesn't work at all #40918

Closed
2 of 5 tasks
hffvld opened this issue Sep 7, 2024 · 2 comments · Fixed by brave/brave-core#25496

Comments

@hffvld
Copy link
Contributor

hffvld commented Sep 7, 2024

Description

Save to Files is missing from the Share menu starting with Brave 1.69 (164). Instead Create PDF is shown, but that option doesn't work.

Steps to reproduce

  1. Launch Brave 1.69 (164) or newer
  2. Open https://basicattentiontoken.org/BasicAttentionTokenWhitePaper-4.pdf or http://www.pdf995.com/samples/pdf.pdf
  3. Tap the Share menu > Observe that Save to Files is missing
  4. Scroll down > Observe that Create PDF is shown
  5. Tap Create PDF > Now tap Save to Files > Observe that the file has no name and is 4KB

Actual result

Save to Files is missing from the Share menu starting with Brave 1.69 (164). Instead Create PDF is shown, but that option doesn't work because the created file has no name and is 4KB in size.


1 2 3 4
1 2 3 4
1 2 3 4

Expected result

The Save to Files option must be shown in the Share menu, so PDF files can be saved locally.


1 2 3
1 2 3

Reproduces how often

Easily reproduced

Brave version

Brave build: 1.69 (165)
BraveCore: 1.69.165 (128.0.6613.127)

Device/iOS version

  • iPhone 14 / iOS 17.6.1
  • iPad Air / iPadOS 16.7.2

Affected browser versions

  • latest AppStore
  • latest TestFlight
  • previous TestFlight

Reproducibility

  • with Brave Shields disabled
  • in the latest version of mobile Safari

Miscellaneous information

No response

@kjozwiak
Copy link
Member

The above requires 1.69.168 or higher for 1.69.x verification 👍

@hffvld
Copy link
Contributor Author

hffvld commented Sep 11, 2024

Verified on iPhone 14 using version(s):

Device/OS: iPhone 14 / iOS 17.6.1
Brave build: 1.69 (168)
BraveCore: 1.69.168 (128.0.6613.138)

STEPS:

  1. Follow the STR/TP from Save to Files is missing from Share menu, and instead Create PDF is shown, which doesn't work at all #40918 (comment)
  2. Verify

ACTUAL RESULTS:

  • Verified that the Save to Files option is shown in the Share menu, and PDF files can be saved locally.

Save PDF

1 2 3
1 2 3

Save website as PDF

1 2 3 4
1 2 3 4

# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants