Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

download of image (generic file?) fails if identical filename present locally (OTF filenames) #41284

Closed
2 of 5 tasks
labor4 opened this issue Sep 28, 2024 · 2 comments · Fixed by brave/brave-core#26865
Closed
2 of 5 tasks

Comments

@labor4
Copy link

labor4 commented Sep 28, 2024

Description

Browsers support the download of files whose filenames are defined in the download attribute of the link, and whose source filenames are supposed to be discarded in favour of that attribute content..

This fails when [filename already present locally] on Brave iOS, but not Safari iOS.
This succeeds when [no such filename conflict present locally]

The download itself is being done, but is shown as failed after completion.

In the reconstruction example I used a download initialized by js.

Steps to reproduce

I did not test against non-OTF (normal) filenames

I think the minimum definition is:

If: [supposed filename is handled on-the-fly, so is not original source/link filename]
then: [Auto-Rename mechanism is not triggered]

The following js download trigger code would currently fail,
if fileName is already present in IOS download dir:

   var link = document.createElement('a');
   link.href = fileUrl;
   link.download = fileName;
   document.body.appendChild(link);
   link.click();
   document.body.removeChild(link);

Actual result

  • download finishes
  • error "download failed"

Expected result

  • download finishes
  • renamed if needed (ie: image-1.png, image-2.png)

Reproduces how often

Easily reproduced

Brave version

1.69.2 (172)

Device/iOS version

17.6.1
iPhone Xs

Affected browser versions

  • latest AppStore
  • latest TestFlight
  • previous TestFlight

Reproducibility

  • with Brave Shields disabled
  • in the latest version of mobile Safari

Miscellaneous information

not an issue in iOS Safari

@labor4 labor4 added the OS/iOS Fixes related to iOS browser functionality label Sep 28, 2024
@bsclifton bsclifton added bug needs-investigation A bug not 100% confirmed/fixed labels Sep 30, 2024
@kylehickinson kylehickinson added QA/Yes release-notes/include and removed needs-investigation A bug not 100% confirmed/fixed labels Dec 4, 2024
@brave-builds brave-builds added this to the 1.75.x - Nightly milestone Dec 4, 2024
@Uni-verse Uni-verse added the QA/In-Progress Indicates that QA is currently in progress for that particular issue label Feb 10, 2025
@Uni-verse
Copy link
Contributor

Verified on iPhone 12 running iOS 18.2 using version 1.75 (175)

Image

example example example
Image Image Image

@Uni-verse
Copy link
Contributor

Uni-verse commented Feb 10, 2025

Verified on iPad (7th Gen) running iOS 18.2.1 using version 1.75 (175)

Image


example example example
Image Image Image

@Uni-verse Uni-verse added QA Pass - iPad and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Feb 10, 2025
@kylehickinson kylehickinson marked this as a duplicate of #44027 Feb 20, 2025
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants