Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Fix broken gn check in rewards_page_handler #41421

Closed
bridiver opened this issue Oct 6, 2024 · 0 comments · Fixed by brave/brave-core#25830
Closed

Fix broken gn check in rewards_page_handler #41421

bridiver opened this issue Oct 6, 2024 · 0 comments · Fixed by brave/brave-core#25830
Assignees
@bridiver
Labels
dev-concern gn_check OS/Desktop QA/No release-notes/exclude
Milestone
1.73.x - Release

Comments

@bridiver
Copy link
Contributor

bridiver commented Oct 6, 2024 

ERROR at //brave/browser/ui/webui/brave_rewards/rewards_page_handler.cc:18:11: Include not allowed.

Due to a merge timing issue between https://github.com/brave/brave-core/pull/25799/files and https://github.com/brave/brave-core/pull/25826/files gn check is broken in main
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@bridiver bridiver

Labels
dev-concern gn_check OS/Desktop QA/No release-notes/exclude
Projects
None yet
Milestone
1.73.x - Release
Development

Successfully merging a pull request may close this issue.

fix gn check that broke again with #25799 brave/brave-core
2 participants
@bridiver @brave-builds