Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

fix gn check that broke again with #25799 #25830

Merged
merged 3 commits into from
Oct 6, 2024
Merged

fix gn check that broke again with #25799 #25830

merged 3 commits into from
Oct 6, 2024

Conversation

bridiver
Copy link
Collaborator

@bridiver bridiver commented Oct 6, 2024 •
edited
Loading

Resolves brave/brave-browser#41421

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@bridiver bridiver requested a review from a team as a code owner October 6, 2024 00:26
@bridiver bridiver enabled auto-merge (squash) October 6, 2024 06:30
@bridiver bridiver disabled auto-merge October 6, 2024 06:31
@bridiver bridiver merged commit a235817 into master Oct 6, 2024
19 checks passed
@bridiver bridiver deleted the rewards-page-gn-check-fix branch October 6, 2024 06:32
@github-actions github-actions bot added this to the 1.72.x - Nightly milestone Oct 6, 2024
@bridiver bridiver mentioned this pull request Oct 6, 2024
Closed
@brave-builds
Copy link
Collaborator

Released in v1.72.64

cdesouza-chromium added a commit that referenced this pull request Oct 9, 2024
@cdesouza-chromium
Revert "fix gn check that broke again with #25799 (#25830)"
2d107f4 
For some unknown reason this PR has broken the Windows debug use of
`json::convert_all_numbers_to_string` and others.

Resolves brave/brave-browser#41497

This reverts commit a235817.
cdesouza-chromium added a commit that referenced this pull request Oct 9, 2024
@cdesouza-chromium
Fix failure calling json function over cxxbridge
6a076d5 
It is not entirely clear what is the underlying mechanism for this
failure, and it should be investigated further. On Windows Debug builds,
any calls to functions like `json::convert_all_numbers_to_string` were
causing a runtime crash. Bisecting our branch has revealed that this
crash started after an entirely unrelated change [1] that in fact seems
quite anodyne.

This change correct the runtime failure with a minimum change.

Resolves brave/brave-browser#41497

[1] #25830
@cdesouza-chromium cdesouza-chromium mentioned this pull request Oct 9, 2024
Merged
24 tasks
cdesouza-chromium added a commit that referenced this pull request Oct 9, 2024
@cdesouza-chromium
Fix failure calling json function over cxxbridge
a3c762c 
It is not entirely clear what is the underlying mechanism for this
failure, and it should be investigated further. On Windows Debug builds,
any calls to functions like `json::convert_all_numbers_to_string` were
causing a runtime crash. Bisecting our branch has revealed that this
crash started after an entirely unrelated change [1] that in fact seems
quite anodyne.

This change correct the runtime failure with a minimum change.

Resolves brave/brave-browser#41497

[1] #25830
cdesouza-chromium added a commit that referenced this pull request Oct 9, 2024
@cdesouza-chromium
Fix failure calling json function over cxxbridge
96d52de 
It is not entirely clear what is the underlying mechanism for this
failure, and it should be investigated further. On Windows Debug builds,
any calls to functions like `json::convert_all_numbers_to_string` were
causing a runtime crash. Bisecting our branch has revealed that this
crash started after an entirely unrelated change [1] that in fact seems
quite anodyne.

This change correct the runtime failure with a minimum change.

Resolves brave/brave-browser#41497

[1] #25830
cdesouza-chromium added a commit that referenced this pull request Oct 9, 2024
@cdesouza-chromium
Fix failure calling json function over cxxbridge
231324e 
It is not entirely clear what is the underlying mechanism for this
failure, and it should be investigated further. On Windows Debug builds,
any calls to functions like `json::convert_all_numbers_to_string` were
causing a runtime crash. Bisecting our branch has revealed that this
crash started after an entirely unrelated change [1] that in fact seems
quite anodyne.

This change correct the runtime failure with a minimum change.

Resolves brave/brave-browser#41497

[1] #25830
cdesouza-chromium added a commit that referenced this pull request Oct 9, 2024
@cdesouza-chromium
Fix failure calling json function over cxxbridge
543bb38 
It is not entirely clear what is the underlying mechanism for this
failure, and it should be investigated further. On Windows Debug builds,
any calls to functions like `json::convert_all_numbers_to_string` were
causing a runtime crash. Bisecting our branch has revealed that this
crash started after an entirely unrelated change [1] that in fact seems
quite anodyne.

This change correct the runtime failure with a minimum change.

Resolves brave/brave-browser#41497

[1] #25830
cdesouza-chromium added a commit that referenced this pull request Oct 9, 2024
@cdesouza-chromium
Fix failure calling json function over cxxbridge (#25898)
4e6b460 
Fix failure calling `json` function over `cxxbridge`

It is not entirely clear what is the underlying mechanism for this
failure, and it should be investigated further. On Windows Debug builds,
any calls to functions like `json::convert_all_numbers_to_string` were
causing a runtime crash. Bisecting our branch has revealed that this
crash started after an entirely unrelated change [1] that in fact seems
quite anodyne.

This change correct the runtime failure with a minimum change.

Resolves brave/brave-browser#41497

[1] #25830
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees

@bridiver bridiver

Labels
None yet
Projects
None yet
Milestone
1.73.x - Release
Development

Successfully merging this pull request may close these issues.

Fix broken gn check in rewards_page_handler
2 participants
@bridiver @brave-builds