Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

[hackerone] Fix interstitial not showing deceptive site warning #41803

Closed
kjozwiak opened this issue Oct 22, 2024 · 1 comment · Fixed by brave/brave-core#26107
Closed

[hackerone] Fix interstitial not showing deceptive site warning #41803

kjozwiak opened this issue Oct 22, 2024 · 1 comment · Fixed by brave/brave-core#26107
Assignees
@Brandon-T
Labels
OS/iOS Fixes related to iOS browser functionality priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass - iPad QA Pass - iPhone QA/Test-All-Platforms QA/Yes release-notes/include security
Milestone
1.70.x - Release #5

Comments

@kjozwiak
Copy link
Member

See https://hackerone.com/reports/2792429.

@Uni-verse @hffvld STR/Cases can be found via https://github.com/brave/internal/issues/1210#issue-2598705116.
@kjozwiak kjozwiak added OS/iOS Fixes related to iOS browser functionality priority/P2 A bad problem. We might uplift this to the next planned release. QA/Test-All-Platforms QA/Yes release-notes/include security labels Oct 22, 2024
@kjozwiak kjozwiak mentioned this issue Oct 22, 2024
Merged
24 tasks
@kjozwiak kjozwiak added this to the 1.73.x - Nightly milestone Oct 22, 2024
@kjozwiak kjozwiak mentioned this issue Oct 22, 2024
Closed
19 tasks
This was referenced Oct 23, 2024
Merged
Merged
Merged
@kjozwiak
Copy link
Member Author

Verification PASSED on iPhone 12 running iOS 18 using the following build(s):

Brave | 1.70.131 Chromium: 129.0.6668.100 (Official Build) stable (64-bit) 
--- | ---
Revision | 12c872a5da009a5c488a97d7c3b66f526e97bad6
OS | iOS

Verification notes for the above can be found via https://github.com/brave/internal/issues/1210#issuecomment-2433259961.

Verification PASSED on iPhone 14 running iOS 17.7 using the following build(s):

Brave | 1.70.131 Chromium: 129.0.6668.100 (Official Build) stable (64-bit) 
--- | ---
Revision | 12c872a5da009a5c488a97d7c3b66f526e97bad6
OS | iOS

Verification notes for the above can be found via https://github.com/brave/internal/issues/1210#issuecomment-2433373450.

Verification PASSED on iPad Air (3rd Gen) running iOS 18 using the following build(s):

Brave | 1.70.131 Chromium: 129.0.6668.100 (Official Build) stable (64-bit) 
--- | ---
Revision | 12c872a5da009a5c488a97d7c3b66f526e97bad6
OS | iOS

Verification notes for the above can be found via https://github.com/brave/internal/issues/1210#issuecomment-2433388282 & https://github.com/brave/internal/issues/1210#issuecomment-2433373450.

@Uni-verse Uni-verse mentioned this issue Oct 25, 2024
Closed
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@Brandon-T Brandon-T

Labels
OS/iOS Fixes related to iOS browser functionality priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass - iPad QA Pass - iPhone QA/Test-All-Platforms QA/Yes release-notes/include security
Projects
None yet
Milestone
1.70.x - Release #5
Development

Successfully merging a pull request may close this issue.

Fix interstitial not showing deceptive site warning. Fix URLBar Eliding brave/brave-core
3 participants
@Brandon-T @kjozwiak @brave-builds