Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Fix interstitial not showing deceptive site warning. Fix URLBar Eliding (1.72.x) #26150

Merged
merged 1 commit into from
Oct 23, 2024
Merged

Fix interstitial not showing deceptive site warning. Fix URLBar Eliding (1.72.x) #26150

merged 1 commit into from
Oct 23, 2024

Conversation

Brandon-T
Copy link
Contributor

@Brandon-T Brandon-T commented Oct 22, 2024 •
edited by kjozwiak
Loading

Uplift of #26107
Resolves https://github.com/brave/internal/issues/1210
Resolves brave/brave-browser#41803

Pre-approval checklist:

  • You have tested your change on Nightly.
  • This contains text which needs to be translated.
    • There are more than 7 days before the release.
    • I've notified folks in #l10n on Slack that translations are needed.
  • The PR milestones match the branch they are landing to.

Pre-merge checklist:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.

Post-merge checklist:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@Brandon-T
Fix interstitial not showing deceptive site warning. Fix URLBar Elidi…
e3766dd 
…ng (#26107)

* Fix interstitial not showing deceptive site warning. Fix URLBar Eliding
* Fix left-alignment and URL parsing for URL-Bar display
* Left align URLs if they are NOT http/https. If the URL-Bar is RTL, then right align them.
@Brandon-T Brandon-T added CI/skip-android Do not run CI builds for Android CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-windows-x64 Do not run CI builds for Windows x64 unused-CI/skip-linux-x64 Do not run CI builds for Linux x64 CI/skip-macos-arm64 Do not run CI builds for macOS arm64 CI/skip-teamcity Do not run builds in TeamCity labels Oct 22, 2024
@Brandon-T Brandon-T self-assigned this Oct 22, 2024
@Brandon-T Brandon-T requested a review from a team as a code owner October 22, 2024 19:57
@kjozwiak kjozwiak added this to the 1.72.x - Beta milestone Oct 23, 2024
kjozwiak
kjozwiak approved these changes Oct 23, 2024
View reviewed changes
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.72.x approved 👍 QA has verified the PR on Nightly using 1.73.x as per #26107 (comment).

@kjozwiak kjozwiak merged commit a246b0c into 1.72.x Oct 23, 2024
16 checks passed
@kjozwiak kjozwiak deleted the bugfix/URL-Bar-Interstitial-Eliding-iOS-1.72.x branch October 23, 2024 01:46
@brave-builds
Copy link
Collaborator

Released in v1.72.86

# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@kjozwiak kjozwiak kjozwiak approved these changes

Assignees

@Brandon-T Brandon-T

Labels
CI/skip-android Do not run CI builds for Android CI/skip-macos-arm64 Do not run CI builds for macOS arm64 CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-teamcity Do not run builds in TeamCity CI/skip-windows-x64 Do not run CI builds for Windows x64 unused-CI/skip-linux-x64 Do not run CI builds for Linux x64
Projects
None yet
Milestone
1.73.x - Release
Development

Successfully merging this pull request may close these issues.
3 participants
@Brandon-T @brave-builds @kjozwiak