Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Missing space between a word and dash in the string Note that — even in private windows — your... #41848

Closed
1 of 6 tasks
hffvld opened this issue Oct 23, 2024 · 1 comment · Fixed by brave/brave-core#26316

Comments

@hffvld
Copy link
Contributor

hffvld commented Oct 23, 2024

Description

Missing space between a word and dash in the string Note that — even in private windows — your....

Steps to reproduce

  1. Launch Brave 1.73.39
  2. Open Private tab > Observe

Actual result

The string is spelled as Note that -even in private windows- your browsing...


Figma 1.73.39
1 2

Expected result

The string must be spelled as Note that — even in private windows — your browsing...

  • Space must be added between a word and dash.
  • Double dash must be used instead.

Reproduces how often

Easily reproduced

Brave version

Brave build: 1.73.39
Chromium: 131.0.6778.14 (Official Build) canary (64-bit)

Device

  • Brand/Model: ANY
  • Android version: ANY

Channel information

  • release (stable)
  • beta
  • nightly

Reproducibility

  • with Brave Shields disabled
  • with Brave Rewards disabled
  • in the latest version of Chrome

Miscellaneous information

No response

@hffvld hffvld added bug OS/Android Fixes related to Android browser functionality QA/Yes feature/private-browsing labels Oct 23, 2024
@hffvld hffvld changed the title [Cr131] Missing space between a word and dash in the string Note that — even in private windows — your... Missing space between a word and dash in the string Note that — even in private windows — your... Oct 24, 2024
@brave-builds brave-builds added this to the 1.75.x - Nightly milestone Nov 14, 2024
@hffvld hffvld added the QA/In-Progress Indicates that QA is currently in progress for that particular issue label Dec 9, 2024
@hffvld
Copy link
Contributor Author

hffvld commented Dec 9, 2024

Verified on Pixel 7 using version(s):

Device/OS: Pixel 7 / panther_beta-user 15 BP11.241025.006 release-keys
Brave build: 1.75.83 
Chromium: 132.0.6834.33 (Official Build) canary (64-bit) 

STEPS:

  1. Follow the STR/TP from Missing space between a word and dash in the string Note that — even in private windows — your... #41848 (comment) and Fix typos in Private Tab brave-core#26316 (comment)
  2. Verify

ACTUAL RESULTS:

  • Verified that dashes were replaced with commas for even in private windows portion and the string looks as:
Note that, even in private windows, your browsing activity may still be visible to your ISP, network observers, or your employer (if you're using a work device/network).

1
1

@hffvld hffvld added QA Pass - Android ARM and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Dec 9, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants