Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Consider using lit-html/custom elements for Brave Education WebUI #42562

Closed
zenparsing opened this issue Nov 27, 2024 · 0 comments · Fixed by brave/brave-core#26154
Closed

Consider using lit-html/custom elements for Brave Education WebUI #42562

zenparsing opened this issue Nov 27, 2024 · 0 comments · Fixed by brave/brave-core#26154
Assignees
@bsclifton @zenparsing
Labels
dev-concern OS/Desktop QA/No release-notes/exclude
Milestone
1.77.x - Nightly

Comments

@zenparsing
Copy link

Description

The Brave education currently WebUI uses vanilla JS on the front-end. Since this WebUI is modeled on Chromium's "what's new" page, we should consider aligning the front-end more closely with that WebUI. The "what's new" page uses lit-html.
@zenparsing zenparsing self-assigned this Nov 27, 2024
@zenparsing zenparsing mentioned this issue Nov 27, 2024
Merged
24 tasks
@zenparsing zenparsing changed the title Consider using lit-html/custom elements for Brave Education WebU Consider using lit-html/custom elements for Brave Education WebUI Nov 27, 2024
bsclifton added a commit to brave/brave-core that referenced this issue Jan 22, 2025
@bsclifton
An attempt to make browser commands closer match upstream.
ba06cc8 
- brave_education is based on whats_new
- brave_browser_commands is based on browser_commands

Fixes brave/brave-browser#42562
bsclifton added a commit to brave/brave-core that referenced this issue Jan 23, 2025
@bsclifton
An attempt to make browser commands closer match upstream.
019edb0 
- brave_education is based on whats_new
- brave_browser_commands is based on browser_commands

Fixes brave/brave-browser#42562

Uses `use_brave_grit` / `brave_or_default_grit` as a
work-around to avoid patching the resources IDs in
`tools/gritsettings/resource_ids.spec`.
bsclifton added a commit to brave/brave-core that referenced this issue Jan 23, 2025
@bsclifton
An attempt to make browser commands closer match upstream.
9c97eae 
- brave_education is based on whats_new
- brave_browser_commands is based on browser_commands

Fixes brave/brave-browser#42562

Uses `use_brave_grit` / `brave_or_default_grit` as a
work-around to avoid patching the resources IDs in
`tools/gritsettings/resource_ids.spec`.
@bsclifton bsclifton self-assigned this Jan 27, 2025
bsclifton added a commit to brave/brave-core that referenced this issue Jan 27, 2025
@bsclifton
An attempt to make browser commands closer match upstream.
668b364 
- brave_education is based on whats_new
- brave_browser_commands is based on browser_commands

Fixes brave/brave-browser#42562

Uses `use_brave_grit` / `brave_or_default_grit` as a
work-around to avoid patching the resources IDs in
`tools/gritsettings/resource_ids.spec`.
@brave-builds brave-builds added this to the 1.77.x - Nightly milestone Jan 30, 2025
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@bsclifton bsclifton

@zenparsing zenparsing

Labels
dev-concern OS/Desktop QA/No release-notes/exclude
Projects
None yet
Milestone
1.77.x - Nightly
Development

Successfully merging a pull request may close this issue.

Implement "Desktop Welcome Pages" feature (v2) brave/brave-core
3 participants
@bsclifton @zenparsing @brave-builds