Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

AI Chat storage notice should dismiss only after the first prompt is sent #42853

Closed
petemill opened this issue Dec 12, 2024 · 2 comments · Fixed by brave/brave-core#26996
Closed

Comments

@petemill
Copy link
Member

(or the close button is pressed)

Test plan

From a query

  1. Fresh profile (or freshly upgraded to the storage flag being unflagged)
  2. Open AI Chat panel (or full-page)
  3. Observe the storage notice shows
  4. Submit a query to Leo
  5. Observe the storage notice disappears
  6. Close and re-open Leo
  7. Observe the storage notice is still not there

From the close button

  1. Fresh profile (or freshly upgraded to the storage flag being unflagged)
  2. Open AI Chat panel (or full-page)
  3. Observe the storage notice shows
  4. Hit the close button
  5. Observe the storage notice disappears
  6. Close and re-open Leo
  7. Observe the storage notice is still not there
@petemill petemill added OS/Android Fixes related to Android browser functionality OS/Desktop QA/Yes release-notes/exclude labels Dec 12, 2024
@petemill petemill self-assigned this Dec 12, 2024
@brave-builds brave-builds added this to the 1.75.x - Nightly milestone Dec 13, 2024
@hffvld hffvld added the QA/In-Progress Indicates that QA is currently in progress for that particular issue label Jan 17, 2025
@hffvld
Copy link
Contributor

hffvld commented Jan 17, 2025

Verified on Galaxy Z Fold 6 using version(s):

Device/OS: Galaxy Z Fold 6 / q6quew-user 14 UP1A.231005.007 release-keys
Brave build: 1.75.159
Chromium: 132.0.6834.83 (Official Build) beta (64-bit) 

STEPS:

  1. Follow the STR/TP from AI Chat storage notice should dismiss only after the first prompt is sent #42853 (comment)
  2. Verify

ACTUAL RESULTS:

  • Verified that the Conversation history storage notice is shown when launching Leo for the first time.
  • Verified that the Conversation history storage notice is not automatically removed when closing Leo or relaunching Brave if no queries were sent to Leo previously.
  • Verified that the Conversation history storage notice is removed and not shown anymore after the first query is sent to Leo.
  • Verified that the Conversation history storage notice is removed and not shown anymore after tapping the x button on the storage notice.

1 2 3
1 2 3
1 2 3

@hffvld hffvld added QA Pass - Android ARM and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Jan 17, 2025
@srirambv
Copy link
Contributor

Verification passed on

Brave 1.75.164 Chromium: 132.0.6834.83 (Official Build) beta (64-bit)
Revision befbba8d7568f8713d6f942f9a7350c59b57f20a
OS Windows 11 Version 24H2 (Build 26100.2894)
  • Verified steps from issue description
  • Verified storage notification is dismissed when a query is posted
  • Verified relaunching browser with the query doesn't show the message again
  • Verified on clean profile closing the storage notification and restarting browser doesn't show the message again
  • Verified reset conversation history via brave://settings/leo-ai doesn't show the message again
42853.-.A.mp4
42853.-.B.mp4

# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants