Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

[Perf] Collecting Brave.Rewards.CustomNotificationPosition hangs browser startup #43964

Closed
atuchin-m opened this issue Feb 13, 2025 · 1 comment · Fixed by brave/brave-core#27649
Closed

[Perf] Collecting Brave.Rewards.CustomNotificationPosition hangs browser startup #43964

atuchin-m opened this issue Feb 13, 2025 · 1 comment · Fixed by brave/brave-core#27649
Assignees
@atuchin-m
Labels
bug feature/ads features/P3A OS/Desktop perf priority/P2 A bad problem. We might uplift this to the next planned release. QA/No release-notes/exclude
Milestone
1.75.x - Release #4

Comments

@atuchin-m
Copy link
Contributor

The main issue that getting the notification status (via NotificationHelper) is synchronously and takes a lot of time:
We're going to move them from UI here: #43712

Anyway calling a lot of blocking platform API is a thing that we always want to postpone if possible.

Image Image
@atuchin-m atuchin-m self-assigned this Feb 13, 2025
@atuchin-m atuchin-m mentioned this issue Feb 13, 2025
Merged
24 tasks
@atuchin-m atuchin-m added priority/P2 A bad problem. We might uplift this to the next planned release. and removed p2a labels Feb 13, 2025
@brave-builds brave-builds added this to the 1.77.x - Nightly milestone Feb 13, 2025
@atuchin-m
Copy link
Contributor Author

The PR fixes the issue with the first navigation delay on the window perf agent:
Image

@atuchin-m atuchin-m mentioned this issue Feb 14, 2025
Open
This was referenced Feb 14, 2025
Merged
Merged
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@atuchin-m atuchin-m

Labels
bug feature/ads features/P3A OS/Desktop perf priority/P2 A bad problem. We might uplift this to the next planned release. QA/No release-notes/exclude
Projects
None yet
Milestone
1.75.x - Release #4
Development

Successfully merging a pull request may close this issue.

Postpone recording Brave.Rewards.CustomNotificationPosition brave/brave-core
3 participants
@kjozwiak @brave-builds @atuchin-m