Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

[Ads, Perf] Create notification_helper_impl only when user joined rewards #43993

Open
atuchin-m opened this issue Feb 14, 2025 · 0 comments
Open

[Ads, Perf] Create notification_helper_impl only when user joined rewards #43993

atuchin-m opened this issue Feb 14, 2025 · 0 comments
Labels
enhancement feature/ads OS/Android Fixes related to Android browser functionality OS/Desktop perf

Comments

@atuchin-m
Copy link
Contributor

atuchin-m commented Feb 14, 2025 •
edited by aseren
Loading

Currently, we always create and init brave/browser/brave_ads/application_state/notification_helper/notification_helper_impl_*.cc even it's a clean profile.
As was investigated in #43964 and #43712 that API could result in some non-trivial work.
We should do this only when user is joined rewards.
@tmancey tmancey added this to Ads Feb 14, 2025
@github-project-automation github-project-automation bot moved this to New issues in Ads Feb 14, 2025
@tmancey tmancey added OS/Desktop OS/Android Fixes related to Android browser functionality labels Feb 14, 2025
@aseren aseren changed the title [Ads, Perf] Create notification_helper_impl on demand [Ads, Perf] Create notification_helper_impl only when user joined rewards Feb 14, 2025
@tmancey tmancey moved this from New issues to To Do in Ads Feb 14, 2025
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
enhancement feature/ads OS/Android Fixes related to Android browser functionality OS/Desktop perf
Projects
Ads
Status: To Do
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tmancey @atuchin-m