Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Dobreprogramy.pl videos are blocked #5456

Closed
btlechowski opened this issue Jul 30, 2019 · 9 comments
Closed

Dobreprogramy.pl videos are blocked #5456

btlechowski opened this issue Jul 30, 2019 · 9 comments

Comments

@btlechowski
Copy link

btlechowski commented Jul 30, 2019

Follow up to #4914. The fix also blocks actual content on the pages.

Steps to Reproduce

  1. Clean install
  2. Open video: https://www.dobreprogramy.pl/Instalujemy-Ferro-Backup-System.-Archiwizacja-danych-w-kilku-krokach,Wideo,102811.html

Note: dobreprogramy is the most popular polish website serving software related content

Actual result:

Video is blocked due to fix in #4914
image

Expected result:

Video is shown
image

Reproduces how often:

Easily reproduced

Brave version (brave://version info)

Brave 0.68.113 Chromium: 76.0.3809.62 (Official Build) beta (64-bit)
Revision 7b77856b3aa34d72f246d12340fc1ded8b2c0e83-refs/branch-heads/3809@{#798}
OS Windows 7 Service Pack 1 (Build 7601.24494)
Brave 0.67.117 Chromium: 76.0.3809.62 (Official Build) (64-bit)
Revision 7b77856b3aa34d72f246d12340fc1ded8b2c0e83-refs/branch-heads/3809@{#798}
OS Windows 7 Service Pack 1 (Build 7601.24494)

cc @brave/legacy_qa @snyderp @rebron @bsclifton

@kjozwiak
Copy link
Member

Reproduced on macOS 10.14.5 x64 using the following build:

Brave 0.68.113 Chromium: 76.0.3809.62 (Official Build) beta (64-bit)
Revision 7b77856b3aa34d72f246d12340fc1ded8b2c0e83-refs/branch-heads/3809@{#798}
OS Mac OS X
Brave 0.70.18 Chromium: 76.0.3809.72 (Official Build) nightly (64-bit)
Revision 5a04c669126f657f98824b436555cae41b8f4146-refs/branch-heads/3809@{#897}
OS Mac OS X

Seeing the following error via the console:

Screen Shot 2019-07-30 at 2 55 48 PM

@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Jul 31, 2019

The issue is Reproducible in Windows 10 x64 - 0.68.114

image

@LaurenWags
Copy link
Member

Reproduced on macOS 10.13.6 with

Brave 0.68.114 Chromium: 76.0.3809.87 (Official Build) beta (64-bit)
Revision 111fe1e15d5ced26080a7dc239bcfe70f6c49aad-refs/branch-heads/3809@{#967}
OS Mac OS X

@bsclifton
Copy link
Member

cc: @ryanbr

ryanbr added a commit to brave/adblock-lists that referenced this issue Aug 2, 2019
@ryanbr
Copy link

ryanbr commented Aug 2, 2019

A fix has been submitted, just needs to be approved. Thanks for the report.

pes10k pushed a commit to brave/adblock-lists that referenced this issue Aug 2, 2019
pes10k pushed a commit to brave/adblock-lists that referenced this issue Aug 2, 2019
@bsclifton
Copy link
Member

@snyderp @ryanbr looks like this was fixed with brave/adblock-lists#146 and then reverted (but not merged) with brave/adblock-lists#147

Are we safe to close it out?

@pes10k
Copy link
Contributor

pes10k commented Sep 3, 2019

This is just waiting for a fresh commit from @ryanbr tying the commit to the brave issue being fixed. Once thats done, this can be merged and closed

@ryanbr
Copy link

ryanbr commented Mar 14, 2020

Disconnect list removed wp.pl a while back, found another issue ^ Will re-check, it'll probably safe to close this report.

@btlechowski
Copy link
Author

btlechowski commented Mar 24, 2020

Good work, I am able to play the video

Verification passed on

Brave 1.7.70 Chromium: 80.0.3987.149 (Official Build) dev (64-bit)
Revision 5f4eb224680e5d7dca88504586e9fd951840cac6-refs/branch-heads/3987_137@{#16}
OS Ubuntu 18.04 LTS

Verified test plan from the description

image


Verified passed with

Brave 1.7.71 Chromium: 80.0.3987.149 (Official Build) dev (64-bit)
Revision 5f4eb224680e5d7dca88504586e9fd951840cac6-refs/branch-heads/3987_137@{#16}
OS macOS Version 10.14.6 (Build 18G3020)
  • Verified STR from description. Confirmed video was able to be played.

Verification passed on

Brave 1.7.74 Chromium: 80.0.3987.149 (Official Build) dev (64-bit)
Revision 5f4eb224680e5d7dca88504586e9fd951840cac6-refs/branch-heads/3987_137@{#16}
OS Windows 10 OS Version 1803 (Build 17134.1006)
  • Verified STR from description. Confirmed video was able to be played.

@btlechowski btlechowski added this to the 1.7.x - Beta milestone Mar 24, 2020
nightsky108 added a commit to nightsky108/adblock-lists that referenced this issue Dec 21, 2021
nightsky108 pushed a commit to nightsky108/adblock-lists that referenced this issue Dec 21, 2021
floresarmida added a commit to floresarmida/adblock-lists that referenced this issue Dec 22, 2021
floresarmida pushed a commit to floresarmida/adblock-lists that referenced this issue Dec 22, 2021
redhawkIT added a commit to redhawkIT/adblock-lists that referenced this issue Dec 22, 2021
redhawkIT pushed a commit to redhawkIT/adblock-lists that referenced this issue Dec 22, 2021
mixazizup added a commit to mixazizup/adblock-lists that referenced this issue Jul 13, 2022
mixazizup pushed a commit to mixazizup/adblock-lists that referenced this issue Jul 13, 2022
tylerc2023 added a commit to tylerc2023/adblock-lists that referenced this issue Sep 8, 2022
tylerc2023 pushed a commit to tylerc2023/adblock-lists that referenced this issue Sep 8, 2022
stevanovicmilan839 added a commit to stevanovicmilan839/adblock-lists that referenced this issue Nov 2, 2022
stevanovicmilan839 pushed a commit to stevanovicmilan839/adblock-lists that referenced this issue Nov 2, 2022
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

No branches or pull requests

7 participants