Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

404 service - archived page recommendation #6144

Closed
rebron opened this issue Sep 24, 2019 · 2 comments · Fixed by brave/brave-core#3561
Closed

404 service - archived page recommendation #6144

rebron opened this issue Sep 24, 2019 · 2 comments · Fixed by brave/brave-core#3561
Assignees
@cezaraugusto @simonhong
Labels
feature/wayback machine priority/P4 Planned work. We expect to get to it "soon". QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include
Milestone
1.4.x - Release

Comments

@rebron
Copy link
Collaborator

rebron commented Sep 24, 2019 •
edited
Loading

When users encounter a 404 error, present them with an option to look up an archived version of the web page (using wayback machine api).
@rebron rebron added the priority/P3 The next thing for us to work on. It'll ride the trains. label Sep 24, 2019
@rebron rebron added priority/P4 Planned work. We expect to get to it "soon". and removed priority/P3 The next thing for us to work on. It'll ride the trains. labels Sep 26, 2019
@cezaraugusto cezaraugusto mentioned this issue Sep 27, 2019
Merged
33 tasks
cezaraugusto added a commit to brave/brave-core that referenced this issue Oct 2, 2019
@cezaraugusto
Add built-in support for the wayback machine
5db1f0e 
close brave/brave-browser#6144
cezaraugusto added a commit to brave/brave-core that referenced this issue Oct 30, 2019
@cezaraugusto
Add basic support for Wayback Machine extension
64fe64a 
This change adds the minimal files for built-in support
address brave/brave-browser#6144
cezaraugusto added a commit to brave/brave-core that referenced this issue Oct 30, 2019
@cezaraugusto
Provide a switch in settings for Wayback Machine
6e00a22 
This adds the ability to turn the Wayback Machine off.
Setting can be located under "extension" sidebar item.

Address brave/brave-browser#6144
@simonhong simonhong self-assigned this Nov 22, 2019
@simonhong
Copy link
Member

@cezaraugusto I'll start to implement infobar UI :)

simonhong pushed a commit to brave/brave-core that referenced this issue Nov 27, 2019
@cezaraugusto @simonhong
Add basic support for Wayback Machine extension
ce1149a 
This change adds the minimal files for built-in support
address brave/brave-browser#6144
simonhong pushed a commit to brave/brave-core that referenced this issue Nov 27, 2019
@cezaraugusto @simonhong
Provide a switch in settings for Wayback Machine
0ff6baf 
This adds the ability to turn the Wayback Machine off.
Setting can be located under "extension" sidebar item.

Address brave/brave-browser#6144
simonhong pushed a commit to brave/brave-core that referenced this issue Dec 4, 2019
@cezaraugusto @simonhong
Add basic support for Wayback Machine extension
bc24147 
This change adds the minimal files for built-in support
address brave/brave-browser#6144
simonhong pushed a commit to brave/brave-core that referenced this issue Dec 4, 2019
@cezaraugusto @simonhong
Provide a switch in settings for Wayback Machine
aeb3004 
This adds the ability to turn the Wayback Machine off.
Setting can be located under "extension" sidebar item.

Address brave/brave-browser#6144
@simonhong simonhong added this to the 1.4.x - Nightly milestone Dec 6, 2019
simonhong pushed a commit to brave/brave-core that referenced this issue Dec 12, 2019
@cezaraugusto @simonhong
Add basic support for Wayback Machine extension
6db994e 
This change adds the minimal files for built-in support
address brave/brave-browser#6144
simonhong pushed a commit to brave/brave-core that referenced this issue Dec 12, 2019
@cezaraugusto @simonhong
Provide a switch in settings for Wayback Machine
f5f66f2 
This adds the ability to turn the Wayback Machine off.
Setting can be located under "extension" sidebar item.

Address brave/brave-browser#6144
simonhong pushed a commit to brave/brave-core that referenced this issue Dec 18, 2019
@cezaraugusto @simonhong
Add basic support for Wayback Machine extension
ed1a1c4 
This change adds the minimal files for built-in support
address brave/brave-browser#6144
simonhong pushed a commit to brave/brave-core that referenced this issue Dec 18, 2019
@cezaraugusto @simonhong
Provide a switch in settings for Wayback Machine
2d0b5f0 
This adds the ability to turn the Wayback Machine off.
Setting can be located under "extension" sidebar item.

Address brave/brave-browser#6144
@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Feb 11, 2020 •
edited by kjozwiak
Loading

Verification passed on

Brave 1.4.84 Chromium: 80.0.3987.87 (Official Build) beta (64-bit)
Revision 449cb163497b70dbf98d389f54e38e85d4c59b43-refs/branch-heads/3987@{#801}
OS Windows 10 OS Version 1803 (Build 17134.1006)
  • Verified the test plan from Add built-in support for the wayback machine brave-core#3561
  • Verified the test plan in Guest/Private/TOR - works as expected
  • Bookmark an archived page brave.com/bo and click on bookmark link shows up archived page upon clicking on Check saved version
  • Verified that archived page is not shown when Show Wayback... switch is turned OFF
  • Verified that archived page is shown in Profile2 even when Wayback switch is turned OFF in Profile 1
  • Verified that archived page brave.com/bo isn't shown when network/wifi is turned OFF

Verification passed on

Brave 1.4.84 Chromium: 80.0.3987.87 (Official Build) beta (64-bit)
Revision 449cb163497b70dbf98d389f54e38e85d4c59b43-refs/branch-heads/3987@{#801}
OS Ubuntu 18.04 LTS

Verified test plan from brave/brave-core#3561. Verified Light and Dark theme

  • Archived page exists
    image
    image

  • Archived page does not exist
    image

  • Disable archived pages
    image

  • Verified status codes: 404, 408, 410, 451, 500, 502, 503, 504, 509, 520, 521, 523, 524, 525, and 526
    image
    image

Dark theme:
image
image

Verification PASSED on macOS 10.15.3 x64 using the following build:

Brave 1.4.93 Chromium: 80.0.3987.116 (Official Build) (64-bit)
Revision dc00a510e4c2ae25c4d084cc3d946fc782249224-refs/branch-heads/3987@{#917}
OS macOS Version 10.15.3 (Build 19D76)
  • Verified the STR outlined via Add built-in support for the wayback machine brave-core#3561
  • ensured that Wayback Machine worked with the following status codes: 404, 408, 410, 451, 500, 502, 503, 504, 509, 520, 521, 523, 524, 525, and 526
  • Verified that selecting X closes the Wayback Machine info bar without any issues
    • ensured that refreshing the same page displays the Wayback Machine info bar
  • ensured that disabling Wayback Machine via brave://settings/braveHelpTips works as expected
  • ensured that the Wayback Machine info bars are not stackable on the same tab
  • ensured that Wayback Machine works under PB/Tor windows

https://brave.com/asd

Examples of Archive pages:

Screen Shot 2020-02-20 at 9 34 58 PM

Screen Shot 2020-02-20 at 9 35 42 PM

Screen Shot 2020-02-20 at 9 41 48 PM

Examples of pages that can't be retrieved from Archive:

Screen Shot 2020-02-20 at 9 37 22 PM

Screen Shot 2020-02-20 at 9 42 01 PM

Example of brave://settings/braveHelpTips:

Screen Shot 2020-02-20 at 9 49 26 PM

@kjozwiak kjozwiak mentioned this issue Feb 25, 2020
Closed
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@cezaraugusto cezaraugusto

@simonhong simonhong

Labels
feature/wayback machine priority/P4 Planned work. We expect to get to it "soon". QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include
Projects
None yet
Milestone
1.4.x - Release
Development

Successfully merging a pull request may close this issue.

Add built-in support for the wayback machine brave/brave-core
7 participants
@kjozwiak @cezaraugusto @rebron @simonhong @LaurenWags @btlechowski @GeetaSarvadnya