Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Fix websocket blocking (uplift to 1.45.x) #15696

Merged
merged 1 commit into from
Oct 28, 2022
Merged

Fix websocket blocking (uplift to 1.45.x) #15696

merged 1 commit into from
Oct 28, 2022

Conversation

brave-builds
Copy link
Collaborator

@brave-builds brave-builds commented Oct 27, 2022 •
edited by kjozwiak
Loading

Uplift of #15679
Resolves brave/brave-browser#26285

Pre-approval checklist:

  • You have tested your change on Nightly.
  • This contains text which needs to be translated.
    • There are more than 7 days before the release.
    • I've notified folks in #l10n on Slack that translations are needed.
  • The PR milestones match the branch they are landing to.

Pre-merge checklist:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.

Post-merge checklist:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@brave-builds brave-builds requested a review from a team as a code owner October 27, 2022 21:28
@brave-builds brave-builds self-assigned this Oct 27, 2022
@brave-builds brave-builds added this to the 1.45.x - Release #3 milestone Oct 27, 2022
@github-actions github-actions bot added the CI/run-network-audit Run network-audit label Oct 27, 2022
kjozwiak
kjozwiak approved these changes Oct 28, 2022
View reviewed changes
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.45.x approved 👍 QA has verified the PR on Nightly as per #15679 (comment).

@kjozwiak kjozwiak merged commit 7ab9f4f into 1.45.x Oct 28, 2022
@kjozwiak kjozwiak deleted the pr15679_fix-websocket-blocking_1.45.x branch October 28, 2022 19:43
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@kjozwiak kjozwiak kjozwiak approved these changes

Assignees

@brave-builds brave-builds

Labels
CI/run-network-audit Run network-audit
Projects
None yet
Milestone
1.45.x - Release #4
Development

Successfully merging this pull request may close these issues.
3 participants
@brave-builds @kjozwiak @brave-browser-releases