-
Notifications
You must be signed in to change notification settings - Fork 899
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Reassign Copy keyboard shortcut to 'copy clean link' #15968
Conversation
49ad7ab
to
9808c3d
Compare
/* Copyright (c) 2022 The Brave Authors. All rights reserved. | ||
* This Source Code Form is subject to the terms of the Mozilla Public | ||
* License, v. 2.0. If a copy of the MPL was not distributed with this file, | ||
* You can obtain one at http://mozilla.org/MPL/2.0/. */ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FYI, we've added a check in CI that looks for an HTTPS URL here and so you'll probably need to change that to https://mozilla.org/MPL/2.0/ before merging.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should not have to make all of these changes just for the shortcut. I need to dig in a little and for now just want to make sure no one else approves
c4f0673
to
513c6d8
Compare
03f2310
to
c90d78a
Compare
|
b5417e5
to
54f20cf
Compare
d6d86af
to
2074022
Compare
24cd791
to
eeaa755
Compare
20fa85b
to
f54c3c4
Compare
4b5e82e
to
24df1e1
Compare
24df1e1
to
7e80ee0
Compare
Closing this PR because it was split for 2 smaller ones: |
Resolves brave/brave-browser#26761
Added few functions to
TextfieldController
because we cannot reach the omibox model directly fromui
layerCopy Clean Link is default for urls:
Copy is default for text:
Submitter Checklist:
QA/Yes
orQA/No
;release-notes/include
orrelease-notes/exclude
;OS/...
) to the associated issuenpm run test -- brave_browser_tests
,npm run test -- brave_unit_tests
,npm run lint
,npm run gn_check
,npm run tslint
git rebase master
(if needed)Reviewer Checklist:
gn
After-merge Checklist:
changes has landed on
Test Plan:
https://brave.com/
was copied. Theutm_campaign
parameter was removed.