Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Refactor Brave Ads served events #16779

Merged
merged 1 commit into from
Feb 1, 2023
Merged

Refactor Brave Ads served events #16779

merged 1 commit into from
Feb 1, 2023

Conversation

tmancey
Copy link
Collaborator

@tmancey tmancey commented Jan 21, 2023

Resolves brave/brave-browser#27942

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run lint, npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

Confirm ads per hour and ads per day frequency caps are working for all creative ad types. Confirm Brave News and New Tab Page ads are working as expected when Brave Ads is disabled.

@tmancey tmancey self-assigned this Jan 21, 2023
@tmancey tmancey requested a review from a team as a code owner January 21, 2023 00:42
@github-actions
Copy link
Contributor

⚠️ PR head is an unsigned commit
commit: 80365c3dde2520cc6d9ffa332d2ba97e0cfd0fdb
reason: unsigned
Please follow the handbook to configure commit signing
cc: @tmancey

2 similar comments
@github-actions
Copy link
Contributor

⚠️ PR head is an unsigned commit
commit: 80365c3dde2520cc6d9ffa332d2ba97e0cfd0fdb
reason: unsigned
Please follow the handbook to configure commit signing
cc: @tmancey

@github-actions
Copy link
Contributor

⚠️ PR head is an unsigned commit
commit: 80365c3dde2520cc6d9ffa332d2ba97e0cfd0fdb
reason: unsigned
Please follow the handbook to configure commit signing
cc: @tmancey

@github-actions
Copy link
Contributor

⚠️ PR head is an unsigned commit
commit: 69ed1b726869e569d60cba4efd6875377c7f3e29
reason: unsigned
Please follow the handbook to configure commit signing
cc: @tmancey

@tmancey tmancey changed the title WIP Refactor Brave Ads served events Jan 21, 2023
@tmancey tmancey force-pushed the issues/27942 branch 3 times, most recently from 127833d to eedc50e Compare January 27, 2023 15:39
@tmancey tmancey force-pushed the issues/27942 branch 2 times, most recently from ac8f0d7 to b544f2b Compare January 30, 2023 15:49
@github-actions
Copy link
Contributor

⚠️ PR head is an unsigned commit
commit: b544f2b55ce6bf8aaf2a901f74a158fa49c59d98
reason: unsigned
Please follow the handbook to configure commit signing
cc: @tmancey

@tmancey tmancey merged commit bb1deb1 into master Feb 1, 2023
@tmancey tmancey deleted the issues/27942 branch February 1, 2023 19:57
@github-actions github-actions bot added this to the 1.49.x - Nightly milestone Feb 1, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor Brave Ads served events
2 participants