-
Notifications
You must be signed in to change notification settings - Fork 924
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Refactor Brave Ads served events #16779
Conversation
|
2 similar comments
|
|
|
127833d
to
eedc50e
Compare
ac8f0d7
to
b544f2b
Compare
|
Resolves brave/brave-browser#27942
Submitter Checklist:
QA/Yes
orQA/No
;release-notes/include
orrelease-notes/exclude
;OS/...
) to the associated issuenpm run test -- brave_browser_tests
,npm run test -- brave_unit_tests
wikinpm run lint
,npm run presubmit
wiki,npm run gn_check
,npm run tslint
git rebase master
(if needed)Reviewer Checklist:
gn
After-merge Checklist:
changes has landed on
Test Plan:
Confirm ads per hour and ads per day frequency caps are working for all creative ad types. Confirm Brave News and New Tab Page ads are working as expected when Brave Ads is disabled.