Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

[Android] Only load http/https URLs when scanning a QR code from the URL bar (uplift to 1.49.x) #17350

Merged
merged 1 commit into from
Feb 28, 2023
Merged

[Android] Only load http/https URLs when scanning a QR code from the URL bar (uplift to 1.49.x) #17350

merged 1 commit into from
Feb 28, 2023

Conversation

brave-builds
Copy link
Collaborator

@brave-builds brave-builds commented Feb 23, 2023 •
edited by kjozwiak
Loading

Uplift of #17344
Resolves brave/brave-browser#28703

Pre-approval checklist:

  • You have tested your change on Nightly.
  • This contains text which needs to be translated.
    • There are more than 7 days before the release.
    • I've notified folks in #l10n on Slack that translations are needed.
  • The PR milestones match the branch they are landing to.

Pre-merge checklist:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.

Post-merge checklist:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@brave-builds brave-builds requested a review from a team as a code owner February 23, 2023 19:27
@brave-builds brave-builds self-assigned this Feb 23, 2023
@brave-builds brave-builds added this to the 1.49.x - Beta milestone Feb 23, 2023
kjozwiak
kjozwiak approved these changes Feb 28, 2023
View reviewed changes
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.49.x approved 👍 QA has verified the PR on Nightly as per #17344 (comment).

@kjozwiak kjozwiak merged commit f9fff70 into 1.49.x Feb 28, 2023
@kjozwiak kjozwiak deleted the pr17344_urlbar_qr_code_scheme_check_android_1.49.x branch February 28, 2023 22:35
@kjozwiak kjozwiak mentioned this pull request Mar 8, 2023
Closed
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@kjozwiak kjozwiak kjozwiak approved these changes

Assignees

@brave-builds brave-builds

Labels
None yet
Projects
None yet
Milestone
1.49.x - Release
Development

Successfully merging this pull request may close these issues.
2 participants
@brave-builds @kjozwiak