Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

[iOS] Fix crash when repeatedly closing NTPs with sponsored images (uplift to 1.65.x) #22877

Merged
merged 1 commit into from
Apr 5, 2024
Merged

[iOS] Fix crash when repeatedly closing NTPs with sponsored images (uplift to 1.65.x) #22877

merged 1 commit into from
Apr 5, 2024

Conversation

brave-builds
Copy link
Collaborator

@brave-builds brave-builds commented Apr 2, 2024 •
edited by kjozwiak
Loading

Uplift of #22874
Resolves brave/brave-browser#37224

Pre-approval checklist:

  • You have tested your change on Nightly.
  • This contains text which needs to be translated.
    • There are more than 7 days before the release.
    • I've notified folks in #l10n on Slack that translations are needed.
  • The PR milestones match the branch they are landing to.

Pre-merge checklist:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.

Post-merge checklist:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@brave-builds brave-builds requested a review from a team as a code owner April 2, 2024 16:07
@brave-builds brave-builds added this to the 1.65.x - Beta milestone Apr 2, 2024
@brave-builds brave-builds self-assigned this Apr 2, 2024
@kylehickinson kylehickinson added CI/skip-android Do not run CI builds for Android CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-windows-x64 Do not run CI builds for Windows x64 labels Apr 2, 2024
kjozwiak
kjozwiak approved these changes Apr 5, 2024
View reviewed changes
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.65.x approved 👍 QA has verified the PR on Nightly using 1.66.x as per #22874 (comment).

@kjozwiak kjozwiak merged commit b26b568 into 1.65.x Apr 5, 2024
15 checks passed
@kjozwiak kjozwiak deleted the pr22874_ios-ntp-p3a-record-crash-pt2_1.65.x branch April 5, 2024 17:12
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@kjozwiak kjozwiak kjozwiak approved these changes

Assignees

@brave-builds brave-builds

Labels
CI/skip-android Do not run CI builds for Android CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-windows-x64 Do not run CI builds for Windows x64
Projects
None yet
Milestone
1.65.x - Release
Development

Successfully merging this pull request may close these issues.
3 participants
@brave-builds @kjozwiak @kylehickinson