Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add https strict mode and interstitial #23337

Merged

Conversation

cuba
Copy link
Contributor

@cuba cuba commented Apr 30, 2024

Resolves brave/brave-browser#36408

Security review: https://github.com/brave/reviews/issues/1593

Will be merged into #23029 before merging into master. Split because the other code has already been reviewed

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

See issue for test plan

Screenshots

https://github.com/brave/brave-core/assets/909331/d0df7137-d78f-408e-9d5f-0b6b4af0e01b
Simulator Screenshot - iPhone 15 Pro - 2024-05-09 at 19 46 29

@cuba cuba changed the base branch from master to js/https-exception-service-ios April 30, 2024 07:32
@cuba cuba changed the title Js/http exception interstitial Add https strict mode and interstitial Apr 30, 2024
@cuba cuba force-pushed the js/http-exception-interstitial branch from ab02580 to c9379c9 Compare April 30, 2024 07:39
@cuba cuba marked this pull request as ready for review April 30, 2024 07:42
@cuba cuba requested a review from a team as a code owner April 30, 2024 07:42
@cuba cuba force-pushed the js/http-exception-interstitial branch from c9379c9 to e3ba10b Compare May 1, 2024 08:38
@cuba cuba merged commit d1795f9 into js/https-exception-service-ios May 7, 2024
14 checks passed
@cuba cuba deleted the js/http-exception-interstitial branch May 7, 2024 16:20
cuba added a commit that referenced this pull request May 8, 2024
* Add HTTPS upgrade checks

* Add https strict mode and interstitial (#23337)

Add http upgrade strict mode and interstitial
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[iOS] HTTPS by default feature on iOS
4 participants