Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

[iOS] Wrap HTTPS-by-default logic around feature flags (Uplift to 1.68.x) #25301

Merged
merged 1 commit into from
Aug 26, 2024
Merged

[iOS] Wrap HTTPS-by-default logic around feature flags (Uplift to 1.68.x) #25301

merged 1 commit into from
Aug 26, 2024

Conversation

kylehickinson
Copy link
Collaborator

@kylehickinson kylehickinson commented Aug 23, 2024 •
edited by kjozwiak
Loading

Uplift of #25263
Resolves brave/brave-browser#40634

Pre-approval checklist:

  • You have tested your change on Nightly.
  • This contains text which needs to be translated.
    • There are more than 7 days before the release.
    • I've notified folks in #l10n on Slack that translations are needed.
  • The PR milestones match the branch they are landing to.

Pre-merge checklist:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.

Post-merge checklist:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@kylehickinson kylehickinson added CI/skip-android Do not run CI builds for Android CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-windows-x64 Do not run CI builds for Windows x64 CI/skip-macos-arm64 Do not run CI builds for macOS arm64 CI/skip-teamcity Do not run builds in TeamCity labels Aug 23, 2024
@kylehickinson kylehickinson requested a review from a team as a code owner August 23, 2024 19:08
@kylehickinson kylehickinson force-pushed the ios-httpsbydefault-flags-1.68.x branch from 8fd725f to b1e586d Compare August 23, 2024 20:05
@kylehickinson kylehickinson force-pushed the ios-httpsbydefault-flags-1.68.x branch from b1e586d to d9f7ea5 Compare August 23, 2024 23:35
@kjozwiak kjozwiak added this to the 1.68.x - Release #8 milestone Aug 26, 2024
kjozwiak
kjozwiak approved these changes Aug 26, 2024
View reviewed changes
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.68.x approved 👍 QA has verified the PR on Nightly using 1.71.x as per #25263 (comment).

@kjozwiak kjozwiak merged commit c7bf4a6 into 1.68.x Aug 26, 2024
14 checks passed
@kjozwiak kjozwiak deleted the ios-httpsbydefault-flags-1.68.x branch August 26, 2024 04:07
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@kjozwiak kjozwiak kjozwiak approved these changes

Assignees

@kylehickinson kylehickinson

Labels
CI/skip-android Do not run CI builds for Android CI/skip-macos-arm64 Do not run CI builds for macOS arm64 CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-teamcity Do not run builds in TeamCity CI/skip-windows-x64 Do not run CI builds for Windows x64
Projects
None yet
Milestone
1.68.x - Release #8
Development

Successfully merging this pull request may close these issues.
2 participants
@kylehickinson @kjozwiak