Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[iOS] - Fix Receipt Linking in TestFlight #25443

Merged
merged 1 commit into from
Sep 5, 2024
Merged

Conversation

Brandon-T
Copy link
Contributor

Resolves brave/brave-browser#40874

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

  • Purchase VPN or Leo on iPhone via Apple Pay
  • Attempt to Link Receipt to the Website
  • Receipt should link successfully

@Brandon-T Brandon-T added CI/skip-android Do not run CI builds for Android CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-windows-x64 Do not run CI builds for Windows x64 unused-CI/skip-linux-x64 Do not run CI builds for Linux x64 CI/skip-macos-arm64 Do not run CI builds for macOS arm64 CI/skip-teamcity Do not run builds in TeamCity labels Sep 5, 2024
@Brandon-T Brandon-T self-assigned this Sep 5, 2024
@Brandon-T Brandon-T requested a review from a team as a code owner September 5, 2024 10:48
@Brandon-T Brandon-T force-pushed the bugfix/ReceiptLinking branch from 192ba6c to a8125a4 Compare September 5, 2024 14:55
Take environment into account when initializing StoreProduct
@Brandon-T Brandon-T force-pushed the bugfix/ReceiptLinking branch from a8125a4 to 7f615db Compare September 5, 2024 20:55
@Brandon-T Brandon-T merged commit ee2459a into master Sep 5, 2024
17 checks passed
@Brandon-T Brandon-T deleted the bugfix/ReceiptLinking branch September 5, 2024 22:09
@github-actions github-actions bot added this to the 1.71.x - Nightly milestone Sep 5, 2024
brave-builds added a commit that referenced this pull request Sep 5, 2024
brave-builds added a commit that referenced this pull request Sep 5, 2024
@hffvld
Copy link
Collaborator

hffvld commented Sep 6, 2024

Verified on iPhone 14 using version(s):

Device/OS: iPhone 14 / iOS 17.6.1
Brave build: 1.71 (64)
BraveCore: 1.71.64 (128.0.6613.120)

STEPS:

  1. Launch Brave
  2. Purchase and enable VPN
  3. Go to VPN settings > Link purchase to your Brave account
  4. # with a test email
  5. Tap Link my subscription now > Verify

ACTUAL RESULTS:

  • Verified that VPN subscription can be linked to the Web

2024-09-05_18-17-00.mp4

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
CI/skip-android Do not run CI builds for Android CI/skip-macos-arm64 Do not run CI builds for macOS arm64 CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-teamcity Do not run builds in TeamCity CI/skip-windows-x64 Do not run CI builds for Windows x64 unused-CI/skip-linux-x64 Do not run CI builds for Linux x64
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[iOS] - Receipt Linking on TestFlight not working
3 participants