-
Notifications
You must be signed in to change notification settings - Fork 922
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
[iOS] - Fix Session Restore URL Display #26099
Conversation
unescapeOptions: .normal | ||
) | ||
} else { | ||
urlDisplayLabel.text = "" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need this part? It wasn't part of the original function
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The original function does: URLFormatter.formatURL(url?.absoluteString ?? "", ....)
which will return empty string if passed an empty string.
So instead of calling the function with an empty string, I just assigned it here.
Please remember to cherry-pick these changes into the uplifts |
Copy code from #26099 and handle data, about, file, wss, etc schemes.
Copy code from #26099 and handle data, about, file, wss, etc schemes.
Copy code from #26099 and handle data, about, file, wss, etc schemes.
Released in v1.73.28 |
Copy code from #26099 and handle data, about, file, wss, etc schemes.
Verified PASSED on Verification was completed via https://github.com/brave/internal/issues/1210#issuecomment-2429631900. |
Uplift of #26099 (squashed) to beta
Uplift of #26099 (squashed) to release
[iOS] - Fix Session Restore URL Display (#26099)
Summary
Resolves brave/brave-browser#41716
Resolves https://github.com/brave/internal/issues/1210
Submitter Checklist:
QA/Yes
orQA/No
;release-notes/include
orrelease-notes/exclude
;OS/...
) to the associated issuenpm run test -- brave_browser_tests
,npm run test -- brave_unit_tests
wikinpm run presubmit
wiki,npm run gn_check
,npm run tslint
git rebase master
(if needed)Reviewer Checklist:
gn
After-merge Checklist:
changes has landed on
Test Plan: