Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

[iOS] Fix crash if internal pages are stopped prior to fully loading (uplift to 1.71.x) #26438

Merged
merged 1 commit into from
Nov 8, 2024
Merged

[iOS] Fix crash if internal pages are stopped prior to fully loading (uplift to 1.71.x) #26438

merged 1 commit into from
Nov 8, 2024

Conversation

kylehickinson
Copy link
Collaborator

@kylehickinson kylehickinson commented Nov 7, 2024 •
edited by kjozwiak
Loading

Uplift of #26434
Resolves brave/brave-browser#42162

Pre-approval checklist:

  • You have tested your change on Nightly.
  • This contains text which needs to be translated.
    • There are more than 7 days before the release.
    • I've notified folks in #l10n on Slack that translations are needed.
  • The PR milestones match the branch they are landing to.

Pre-merge checklist:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.

Post-merge checklist:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@kylehickinson kylehickinson requested a review from a team as a code owner November 7, 2024 19:09
@kylehickinson kylehickinson added CI/skip-android Do not run CI builds for Android CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-windows-x64 Do not run CI builds for Windows x64 CI/skip-macos-arm64 Do not run CI builds for macOS arm64 CI/skip-teamcity Do not run builds in TeamCity labels Nov 7, 2024
@kjozwiak kjozwiak added this to the 1.71.x - Release #5 milestone Nov 8, 2024
kjozwiak
kjozwiak approved these changes Nov 8, 2024
View reviewed changes
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.71.x approved 👍

@kjozwiak kjozwiak merged commit 598114c into 1.71.x Nov 8, 2024
16 checks passed
@kjozwiak kjozwiak deleted the ios-web-internals-crash-1.71.x branch November 8, 2024 04:02
@brave-builds
Copy link
Collaborator

Released in v1.71.125

# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@kjozwiak kjozwiak kjozwiak approved these changes

Assignees

@kylehickinson kylehickinson

Labels
CI/skip-android Do not run CI builds for Android CI/skip-macos-arm64 Do not run CI builds for macOS arm64 CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-teamcity Do not run builds in TeamCity CI/skip-windows-x64 Do not run CI builds for Windows x64
Projects
None yet
Milestone
1.71.x - Release #5
Development

Successfully merging this pull request may close these issues.
3 participants
@kylehickinson @brave-builds @kjozwiak