Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Remove Emarsys / Scarab trackers from URLs #27105

Merged
merged 1 commit into from
Jan 3, 2025
Merged

Conversation

fmarier
Copy link
Member

@fmarier fmarier commented Jan 1, 2025

Fixes brave/brave-browser#43077

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

  1. In a new browser profile with standard Shields.
  2. Open https://brave.com/?abc=123&sc_customer=1&sc_eh=2&sc_uid=3.
  3. Confirm that the URL bar just shows https://brave.com/?abc=123.

@fmarier fmarier requested a review from ryanbr January 1, 2025 00:30
@fmarier fmarier self-assigned this Jan 1, 2025
@fmarier fmarier added this to the 1.75.x - Nightly milestone Jan 1, 2025
@ryanbr
Copy link
Collaborator

ryanbr commented Jan 2, 2025

||puma.com^$removeparam=sc_src
||puma.com^$removeparam=sc_lid
||puma.com^$removeparam=sc_uid
||puma.com^$removeparam=sc_llid
||puma.com^$removeparam=sc_eh
||avansas.com^$removeparam=sc_src
||avansas.com^$removeparam=sc_llid
||avansas.com^$removeparam=sc_lid
||avansas.com^$removeparam=sc_uid
||avansas.com^$removeparam=sc_customer

Could we re-use any of these (from ADG url tracking) @fmarier

@fmarier
Copy link
Member Author

fmarier commented Jan 2, 2025

||puma.com^$removeparam=sc_src
||puma.com^$removeparam=sc_lid
||puma.com^$removeparam=sc_uid
||puma.com^$removeparam=sc_llid
||puma.com^$removeparam=sc_eh
||avansas.com^$removeparam=sc_src
||avansas.com^$removeparam=sc_llid
||avansas.com^$removeparam=sc_lid
||avansas.com^$removeparam=sc_uid
||avansas.com^$removeparam=sc_customer

Could we re-use any of these (from ADG url tracking) @fmarier

See brave/adblock-lists#2241 for the full clean-up. These are just for the user-tracking params.

@fmarier fmarier merged commit 2a3f555 into master Jan 3, 2025
19 checks passed
@fmarier fmarier deleted the emarsys-trackers-43077 branch January 3, 2025 20:12
@brave-builds
Copy link
Collaborator

Released in v1.75.147

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove Emarsys / Scarab trackers from URLs
3 participants