Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

X86 linux package sym deps #40

Merged
merged 2 commits into from
Feb 26, 2018
Merged

X86 linux package sym deps #40

merged 2 commits into from
Feb 26, 2018

Conversation

AlexeyBarabash
Copy link
Contributor

  1. deps from "//chrome" is required to have brave binary ready when tools/posix/generate_breakpad_symbols.py runs.
  2. try/finally is required in tools/posix/generate_breakpad_symbols.py to avoid endless wait on queue.join() when exception happens.

@bbondy bbondy merged commit 91bc123 into master Feb 26, 2018
@bsclifton bsclifton deleted the x86_linux_package_sym_deps branch June 18, 2018 06:26
NejcZdovc pushed a commit that referenced this pull request Dec 10, 2018
@gdregalo
Fix:Recovery keys from muon are not working #40
b600bb1
NejcZdovc pushed a commit that referenced this pull request Dec 10, 2018
@SergeyZhukovsky
Merge pull request #53 from brave-intl/recovery_key_fix
5428f82 
Fix:Recovery keys from muon are not working #40
bbondy pushed a commit that referenced this pull request Feb 18, 2019
@cezaraugusto
Merge pull request #40 from brave/fix_disabled_icon_path
bdf4ea1 
Fix icon paths used in setIcon
@CxsLucyfer CxsLucyfer mentioned this pull request Apr 23, 2024
Open
@kingjay66 kingjay66 mentioned this pull request Apr 23, 2024
Open
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@bbondy bbondy bbondy approved these changes

@bridiver bridiver Awaiting requested review from bridiver

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AlexeyBarabash @bbondy