-
Notifications
You must be signed in to change notification settings - Fork 925
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Adding option to remove sites from auto-contribute #420
Conversation
fea159b
to
e54ea8b
Compare
e54ea8b
to
5a79c66
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jasonrsadler good catch, will fix |
5a79c66
to
89da6f6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
++ Good job! Works good!
Adding option to remove sites from auto-contribute
For next time pls also add |
@@ -39,11 +39,15 @@ class ContributeBox extends React.Component<Props, State> { | |||
} | |||
} | |||
|
|||
getContributeRows = (list: Rewards.Publisher[]) => { | |||
getIncludedPublishers = (list: Rewards.Publisher[]) => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this should be done on DB level
@NejcZdovc I need to be able to show the number of excluded sites for contribute modals restore option, if we fetch only the included publishers, I won't be able to calculate the difference. What do you suggest? Fetching only the count? |
@NejcZdovc - you want to see something like:
|
@ryanml something like this
|
Addresses: brave/brave-browser#967
Native ledger work:
brave-intl/bat-native-ledger#87
brave-intl/bat-native-ledger#93
Submitter Checklist:
git rebase -i
to squash commits (if needed).Test Plan:
See all ${n} sites
to display the removal modalx
icon next to a few publishersReviewer Checklist: