Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

migrate android toolbar settings (uplift to 1.5.x) #4972

Merged
merged 1 commit into from
Mar 18, 2020
Merged

migrate android toolbar settings (uplift to 1.5.x) #4972

merged 1 commit into from
Mar 18, 2020

Conversation

SergeyZhukovsky
Copy link
Member

Uplift of #4970

@SergeyZhukovsky SergeyZhukovsky added CI/skip-linux CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-ios Do not run CI builds for iOS labels Mar 17, 2020
@SergeyZhukovsky SergeyZhukovsky requested a review from a team March 17, 2020 23:16
@SergeyZhukovsky SergeyZhukovsky added this to the 1.5.x milestone Mar 17, 2020
@kjozwiak
Copy link
Member

Restarting as the b-b job never started. Most likely due to https://github.com/brave/brave-browser/milestone/72 being closed earlier today after 1.5.112 CR: 80.0.3987.132 was released as per the following:

ERROR: No item named brave-browser-build-pr/pr4970_android_toolbar_migration_1.5.x found
Finished: FAILURE

@kjozwiak
Copy link
Member

Travis is failing TEST_SUITE=test-security due to the minimist npm package being vulnerable. It's a known issue as per brave/brave-browser#8722 and doesn't block the PR from being uplifted.

kjozwiak
kjozwiak approved these changes Mar 18, 2020
View reviewed changes
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.5.x approved after deliberating with @brave/uplift-approvers. As per #4972 (comment), Travis failed due to TEST_SUITE=test-security because of minimist which is a known issue and highlighted via brave/brave-browser#8722.

Please make sure that all the correct labels are being used and the associated issue is moved into the correct milestone.

@kjozwiak kjozwiak merged commit a45154a into 1.5.x Mar 18, 2020
@kjozwiak kjozwiak deleted the pr4970_android_toolbar_migration_1.5.x branch March 18, 2020 05:41
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@kjozwiak kjozwiak kjozwiak approved these changes

Assignees

@brave-builds brave-builds

Labels
CI/skip-ios Do not run CI builds for iOS CI/skip-macos-x64 Do not run CI builds for macOS x64
Projects
None yet
Milestone
1.5.x - placeholder
Development

Successfully merging this pull request may close these issues.
3 participants
@SergeyZhukovsky @kjozwiak @brave-builds