Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Reload active tab when widevine library is ready to use (uplift to 1.7.x) #5070

Merged
merged 1 commit into from
Mar 27, 2020

Conversation

bsclifton
Copy link
Member

@bsclifton bsclifton commented Mar 26, 2020

Uplift of #4978
Fixes brave/brave-browser#4646

Approved, please ensure that before merging:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.
  • You have tested your change on Nightly.
  • The PR milestones match the branch they are landing to.

After you merge:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@bsclifton bsclifton added this to the 1.7.x - Beta milestone Mar 26, 2020
@bsclifton bsclifton requested a review from a team March 26, 2020 16:41
@bsclifton bsclifton requested a review from simonhong as a code owner March 26, 2020 16:41
@bsclifton bsclifton self-assigned this Mar 26, 2020
@bsclifton
Copy link
Member Author

redo of #5049 after discussion on Slack:
https://bravesoftware.slack.com/archives/CHGKGMHDJ/p1585160096007100

@bsclifton
Copy link
Member Author

bsclifton commented Mar 26, 2020

Related (reported when testing this issue) - Netflix does not work due to Widevine Content Decryption Module error in brave://components

@kjozwiak
Copy link
Member

Restarting macOS as test-browser failed as per https://ci.brave.com/job/brave-browser-build-pr/job/pr4978_issue_4646_widevine_1.7.x/3/execution/node/494/log/

14:28:39  [508/508] BraveRewardsBrowserTest.TipConnectedPublisherAnonAndConnected (TIMED OUT)
14:28:39  1 test timed out:
14:28:39      BraveRewardsBrowserTest.TipConnectedPublisherAnonAndConnected (../../brave/components/brave_rewards/browser/rewards_service_browsertest.cc:2762)

Even though the above isn't related to Widevine, restarting just in case to make sure the above failure is intermittent.

@kjozwiak kjozwiak added CI/skip-android Do not run CI builds for Android CI/skip-ios Do not run CI builds for iOS CI/skip-linux labels Mar 26, 2020
@kjozwiak
Copy link
Member

Travis is failing TEST_SUITE=test-security due to the minimist npm package being vulnerable. It's a known issue as per brave/brave-browser#8722 and doesn't block the PR from being uplifted.

@kjozwiak
Copy link
Member

Looks like it timed out as per the following:

19:53:45  [507/507] BraveRewardsBrowserTest.TipConnectedPublisherAnonAndConnected (TIMED OUT)
19:53:45  1 test timed out:
19:53:45      BraveRewardsBrowserTest.TipConnectedPublisherAnonAndConnected (../../brave/components/brave_rewards/browser/rewards_service_browsertest.cc:2762)

@bsclifton created brave/brave-browser#8881 to address the above timeout.

Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.7.x approved after deliberating with @brave/uplift-approvers. Please make sure that all the correct labels are being used and the associated issue is moved into the correct milestone.

@kjozwiak kjozwiak merged commit 19548e8 into 1.7.x Mar 27, 2020
@kjozwiak kjozwiak deleted the pr4978_issue_4646_widevine_1.7.x branch March 27, 2020 05:19
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
CI/skip-android Do not run CI builds for Android CI/skip-ios Do not run CI builds for iOS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants