Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Only override Widevine if supported #509

Merged
merged 1 commit into from
Sep 26, 2018
Merged

Only override Widevine if supported #509

merged 1 commit into from
Sep 26, 2018

Conversation

mbacchi
Copy link
Contributor

@mbacchi mbacchi commented Sep 26, 2018

Fixes brave/brave-browser#1304

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.
  • Request a security/privacy review as needed.
  • Add appropriate QA labels (QA/Needed or QA/No-QA-Needed) to include the closed issue in milestone

Test Plan:

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

@mbacchi mbacchi requested review from bbondy and darkdh September 26, 2018 21:44
@bbondy bbondy merged commit 75dc52c into master Sep 26, 2018
bbondy added a commit that referenced this pull request Sep 26, 2018
Only override Widevine if supported
@bsclifton bsclifton deleted the issue1304 branch September 26, 2018 21:48
bbondy added a commit that referenced this pull request Sep 26, 2018
Only override Widevine if supported
@bbondy
Copy link
Member

bbondy commented Sep 26, 2018

master 75dc52c
0.56.x 1553b72
0.55.x cb972d4

darkdh added a commit that referenced this pull request Sep 26, 2018
darkdh added a commit that referenced this pull request Sep 26, 2018
darkdh added a commit that referenced this pull request Sep 26, 2018
@bbondy bbondy added this to the 0.55.x - Release milestone Jan 14, 2019
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Linux build fails with error: unknown type name 'WidevineCdmComponentInstallerPolicy'
2 participants