Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Changed icon for btn_right (uplift to 1.5.x) #5094

Merged
merged 1 commit into from
Mar 30, 2020
Merged

Changed icon for btn_right (uplift to 1.5.x) #5094

merged 1 commit into from
Mar 30, 2020

Conversation

brave-builds
Copy link
Collaborator

@brave-builds brave-builds commented Mar 30, 2020 •
edited by kjozwiak
Loading

Uplift of #5091

Approved, please ensure that before merging:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.
  • You have tested your change on Nightly.
  • The PR milestones match the branch they are landing to.

After you merge:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@brave-builds brave-builds self-assigned this Mar 30, 2020
@brave-builds brave-builds added this to the 1.5.x - placeholder milestone Mar 30, 2020
@samartnik samartnik added CI/skip-ios Do not run CI builds for iOS CI/skip-linux CI/skip-macos-x64 Do not run CI builds for macOS x64 labels Mar 30, 2020
@kjozwiak
Copy link
Member

Looks like dist failed as per https://ci.brave.com/job/brave-browser-build-pr/job/pr5091_android_btn_right_icon_change_1.5.x/1/execution/node/365/log/. Going to quickly restart as it shouldn't take too long to retry just on Android.

@kjozwiak
Copy link
Member

Travis is failing TEST_SUITE=test-security due to the minimist npm package being vulnerable. It's a known issue as per brave/brave-browser#8722 and doesn't block the PR from being uplifted.

kjozwiak
kjozwiak approved these changes Mar 30, 2020
View reviewed changes
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.5.x approved after deliberating with @brave/uplift-approvers. Please make sure that all the correct labels are being used and the associated issue is moved into the correct milestone.

@kjozwiak kjozwiak merged commit 80b696c into 1.5.x Mar 30, 2020
@kjozwiak kjozwiak deleted the pr5091_android_btn_right_icon_change_1.5.x branch March 30, 2020 19:25
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@kjozwiak kjozwiak kjozwiak approved these changes

@bbondy bbondy Awaiting requested review from bbondy

@bsclifton bsclifton Awaiting requested review from bsclifton

@rebron rebron Awaiting requested review from rebron

@srirambv srirambv Awaiting requested review from srirambv

Assignees

@brave-builds brave-builds

Labels
CI/skip-ios Do not run CI builds for iOS CI/skip-macos-x64 Do not run CI builds for macOS x64
Projects
None yet
Milestone
1.5.x - placeholder
Development

Successfully merging this pull request may close these issues.
4 participants
@brave-builds @kjozwiak @samartnik @brave-browser-releases