Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Change gaia URL to be no-thanks.invalid #512

Merged
merged 1 commit into from
Sep 27, 2018
Merged

Change gaia URL to be no-thanks.invalid #512

merged 1 commit into from
Sep 27, 2018

Conversation

bbondy
Copy link
Member

@bbondy bbondy commented Sep 27, 2018

Steps to reproduce:

  1. Start the browser and log into google.
  2. Open settings.
  3. Close the browser
  4. Open the browser with command line params: --log-net-log=/some/file.json --net-log-capture-mode=IncludeSocketBytes
  5. Open up the json file path you mentioned.

Before this fix you should see:

 https://accounts.google.com/ListAccounts?gpsia=1&source=durations_metrics,counter:0,load_time_ms:154&json=standard

After this fix, you should see:

 https://no-thanks.invalid/ListAccounts?gpsia=1&source=durations_metrics,counter:0,load_time_ms:154&json=standard

Note: .invalid is a reserved TLD and is always explicitly invalid.

Test plan:

  1. Do the above
  2. Make sure google services still work.

Fix brave/brave-browser#1312
See also brave/brave-browser#527

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.
  • Request a security/privacy review as needed.
  • Add appropriate QA labels (QA/Needed or QA/No-QA-Needed) to include the closed issue in milestone

Test Plan:

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

Copy link
Member

@petemill petemill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as expected. Log shows no-thanks.invalid entries, unless visiting other tabs. Console shows gaia connect error.

@bbondy bbondy merged commit 9b42ea4 into master Sep 27, 2018
bbondy added a commit that referenced this pull request Sep 27, 2018
Change gaia URL to be no-thanks.invalid
bbondy added a commit that referenced this pull request Sep 27, 2018
Change gaia URL to be no-thanks.invalid
@bbondy
Copy link
Member Author

bbondy commented Sep 27, 2018

master: 9b42ea4
0.56.x: da5a3c4
0.55.x: 41b84bf

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change gaia URL to be no-thanks.invalid
2 participants