Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Adds pagination to publisher list #5458

Merged
merged 1 commit into from
May 6, 2020
Merged

Adds pagination to publisher list #5458

merged 1 commit into from
May 6, 2020

Conversation

NejcZdovc
Copy link
Contributor

@NejcZdovc NejcZdovc commented May 4, 2020

Resolves brave/brave-browser#9607

Submitter Checklist:

Test Plan:

  • make sure that list downloads and verified publisher show up (Test it on staging)

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

@NejcZdovc NejcZdovc self-assigned this May 4, 2020
@NejcZdovc NejcZdovc added this to the 1.10.x - Nightly milestone May 5, 2020
@NejcZdovc NejcZdovc marked this pull request as ready for review May 5, 2020 16:35
@NejcZdovc NejcZdovc requested a review from gdregalo as a code owner May 5, 2020 16:35
@NejcZdovc NejcZdovc force-pushed the pub-list-pagination branch from 9b0767f to a1f9a90 Compare May 5, 2020 16:35
@NejcZdovc NejcZdovc requested a review from a team May 5, 2020 16:36
Copy link
Contributor

@emerick emerick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just had one comment

@NejcZdovc NejcZdovc force-pushed the pub-list-pagination branch from 43cd464 to e777715 Compare May 6, 2020 06:06
@NejcZdovc NejcZdovc merged commit ba50382 into master May 6, 2020
@NejcZdovc NejcZdovc deleted the pub-list-pagination branch May 6, 2020 12:01
@LaurenWags
Copy link
Member

Verified passed with

Brave | 1.10.39 Chromium: 81.0.4044.138 (Official Build) nightly (64-bit)
-- | --
Revision | 8c6c7ba89cc9453625af54f11fd83179e23450fa-refs/branch-heads/4044@{#999}
OS | macOS Version 10.14.6 (Build 18G3020)

Screen Shot 2020-05-08 at 4 06 40 PM

  • Confirmed display of custom tip banner for both one time and monthly tips:

Screen Shot 2020-05-08 at 4 06 50 PM

Screen Shot 2020-05-08 at 4 11 27 PM

  • Confirmed if I connect a KYC'd user wallet, I am able to see connected, but not KYC'd publishers as verified w/ proper messaging on panel and tip banners:

Screen Shot 2020-05-08 at 4 13 16 PM

Screen Shot 2020-05-08 at 4 13 26 PM

Screen Shot 2020-05-08 at 4 13 36 PM

  • Confirmed able to see verified websites, YouTube channels above and confirmed able to see verified Twitch, GitHub, Reddit, Vimeo, and Twitter pages also.

Screen Shot 2020-05-08 at 4 16 50 PM

Screen Shot 2020-05-08 at 4 17 08 PM

Screen Shot 2020-05-08 at 4 17 51 PM

Screen Shot 2020-05-08 at 4 17 28 PM

Screen Shot 2020-05-08 at 4 18 07 PM

@LaurenWags
Copy link
Member

Verified passed with

Brave | 1.10.39 Chromium: 81.0.4044.138 (Official Build) canary (32-bit)
-- | --
Revision | 8c6c7ba89cc9453625af54f11fd83179e23450fa-refs/branch-heads/4044@{#999}
OS | Android 10; Pixel 3 XL Build/QQ2A.200305.002

# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement pagination for publisher list
5 participants