Fixes old promotions not being displayed in the total #5569
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NejcZdovc
commented
May 15, 2020
| "INNER JOIN creds_batch as cb ON cb.creds_id = ut.creds_id " | ||
| "WHERE cb.trigger_id IN (%s)", | ||
| "LEFT JOIN creds_batch as cb ON cb.creds_id = ut.creds_id " | ||
| "WHERE cb.trigger_id IN (%s) OR ut.creds_id IS NULL", |
There was a problem hiding this comment.
This check is ok as only old promotions will have null
zenparsing
approved these changes
May 15, 2020
vendor/bat-native-ledger/src/bat/ledger/internal/database/database_unblinded_token.cc
Outdated
Show resolved
Hide resolved
NejcZdovc
force-pushed
the
balance-display
branch
from
3029995 to
2d8ae48
Compare
NejcZdovc
added
CI/skip-ios
|
CI timed out on android, everything else was good. Restarting |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves brave/brave-browser#9796
Submitter Checklist:
npm run lint)git rebase master(if needed).git rebase -ito squash commits (if needed).Test Plan:
Reviewer Checklist:
After-merge Checklist:
changes has landed on.