Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add button to perform garbage collection sweep #8005

Merged
merged 1 commit into from
Feb 22, 2021
Merged

Add button to perform garbage collection sweep #8005

merged 1 commit into from
Feb 22, 2021

Conversation

spylogsster
Copy link
Contributor

@spylogsster spylogsster commented Feb 19, 2021

Resolves brave/brave-browser#13554
Resolves brave/brave-browser#14300

Screenshot 2021-02-19 at 13 16 52

Screenshot 2021-02-19 at 13 16 57

Screenshot 2021-02-19 at 13 19 56

Submitter Checklist:

  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)
  • Requested a security/privacy review as needed

Reviewer Checklist:

  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

  • Button should appear only when node launched and run garbage collection

@spylogsster spylogsster requested a review from bbondy February 19, 2021 12:38
@spylogsster spylogsster self-assigned this Feb 19, 2021
@spylogsster spylogsster force-pushed the add-gc-sweep branch 2 times, most recently from 25de52e to a4a86ab Compare February 19, 2021 14:59
@bbondy bbondy merged commit e78c962 into master Feb 22, 2021
@bbondy bbondy deleted the add-gc-sweep branch February 22, 2021 20:28
@bbondy bbondy added this to the 1.22.x - Nightly milestone Feb 22, 2021
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
2 participants