-
Notifications
You must be signed in to change notification settings - Fork 925
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Removed ntp tile outline #8327
Removed ntp tile outline #8327
Conversation
I don't think we need this anymore - looks fixed w/ Chromium 90. @simonhong can you verify? Tiles PR was in 1.23 which will also feature Chromium 90 |
698761c
to
74b46be
Compare
@bsclifton I confirmed that latest nightly (c90) still has this issue. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works great! 😄
re-run macos CI only. others are fine with previous run. |
Looking at the change a bit further (and trying things with dev tools). The right kind of fix might be to instead specify |
74b46be
to
9436972
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
see comment (my bad)
9436972
to
8939b70
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two below browser tests are failed only on linux and both are definitely not related with this PR's change. Merged. |
fix brave/brave-browser#14802
Resolves

Submitter Checklist:
QA/Yes
orQA/No
;release-notes/include
orrelease-notes/exclude
;OS/...
) to the associated issuenpm run test -- brave_browser_tests
,npm run test -- brave_unit_tests
,npm run lint
,npm run gn_check
,npm run tslint
git rebase master
(if needed)Reviewer Checklist:
gn
After-merge Checklist:
changes has landed on
Test Plan: