Listen for referral headers updates #892
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We were previously only retrieving the referral headers on first launch. Aside from preventing us from incorporating potential updates to the headers, this also made it so that a browser restart was required the first time a user initialized the referral (as the referral headers would still be empty from the network delegate's perspective). Now we register for changes to that preference and pull them in on the fly.
bbondy
approved these changes
Nov 12, 2018
|
@emerick can we get this uplifted into |
|
does @aekeus need this for 0.57.x? |
emerick
added a commit
that referenced
this pull request
Nov 28, 2018
Listen for referral for referral headers updates
emerick
changed the title
|
@emerick uplift approved for 0.57.x. Please update label once merged to 0.57.x |
emerick
added a commit
that referenced
this pull request
Nov 28, 2018
Listen for referral for referral headers updates
|
0.57.x has wrong changeset above but it is actually landed: |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes brave/brave-browser#2020
We were previously only retrieving the referral headers on first
launch. Aside from preventing us from incorporating potential updates
to the headers, this also made it so that a browser restart was
required the first time a user initialized the referral (as the
referral headers would still be empty from the network delegate's
perspective).
Now we register for changes to that preference and pull them in on the
fly.
Submitter Checklist:
npm test brave_unit_tests && npm test brave_browser_tests) ongit rebase master(if needed).git rebase -ito squash commits (if needed).Test Plan:
BraveBrowserSetup-dowjones-marketwatch.exe)X-Brave-PartnerReviewer Checklist: