Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Handle offline cases for sync #973

Merged
merged 3 commits into from
Nov 29, 2018
Merged

Handle offline cases for sync #973

merged 3 commits into from
Nov 29, 2018

Conversation

darkdh
Copy link
Member

@darkdh darkdh commented Nov 28, 2018

fix brave/brave-browser#2139
fix brave/brave-browser#2137
fix brave/brave-browser#2278

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Verified that these changes build without errors on
    • Windows
    • macOS
    • Linux
  • Verified that these changes pass automated tests (npm test brave_unit_tests && npm test brave_browser_tests) on
    • Windows
    • macOS
    • Linux
  • Ran git rebase master (if needed).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.
  • Request a security/privacy review as needed.
  • Add appropriate QA labels (QA/Yes or QA/No) to include the closed issue in milestone

Test Plan:

Unit test

  • npm run test -- brave_unit_tests --filter=BraveSyncServiceTest.*

Manual tests

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

@darkdh darkdh changed the title WIP: Handle offline cases for sync Handle offline cases for sync Nov 29, 2018
Copy link
Contributor

@AlexeyBarabash AlexeyBarabash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

@darkdh darkdh merged commit af8537b into master Nov 29, 2018
darkdh added a commit that referenced this pull request Nov 29, 2018
Handle offline cases for sync
darkdh added a commit that referenced this pull request Nov 29, 2018
Handle offline cases for sync
@darkdh
Copy link
Member Author

darkdh commented Nov 29, 2018

master: af8537b
0.58.x: 043bac7
0.57.x: b653a19

bbondy added a commit that referenced this pull request Nov 29, 2018
@bbondy
Copy link
Member

bbondy commented Nov 29, 2018

Reverted from 0.57.x due to no approval:
e87c177

@darkdh darkdh deleted the sync-offline branch December 14, 2018 23:12
@bbondy bbondy added this to the 0.58.x - Release milestone Jan 14, 2019
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
3 participants